Skip to content

chore(python): examples for client_supplier #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025

Conversation

imabhichow
Copy link

Issue #, if available:

Description of changes:

  1. examples for client_supplier

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content LGTM -- pending CI being fixed by another PR before approving

@imabhichow imabhichow force-pushed the imabhichow/python-examples-clientsupplier branch from 8689c5c to 1bdc2e2 Compare May 29, 2025 15:10
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Since CI is passing, you should do the following:

  • Change base branch to python-reviewed
  • Squash and merge. (Ignore failing CI, that's expected)

@imabhichow imabhichow changed the base branch from python-poc to python-reviewed May 30, 2025 17:28
@imabhichow imabhichow force-pushed the imabhichow/python-examples-clientsupplier branch from 34fda84 to b55c13f Compare May 30, 2025 17:40
@imabhichow imabhichow changed the title WIP chore(python): examples for client_supplier chore(python): examples for client_supplier May 30, 2025
@imabhichow imabhichow marked this pull request as ready for review May 30, 2025 19:45
@imabhichow imabhichow requested a review from a team as a code owner May 30, 2025 19:45
@imabhichow imabhichow merged commit 112798d into python-reviewed May 30, 2025
71 of 82 checks passed
@imabhichow imabhichow deleted the imabhichow/python-examples-clientsupplier branch May 30, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants