WIP chore(python): examples for encrypted table #1928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 10, 2025 10:57
| """ | ||
| Configuration module for hierarchical keyring encryption setup. | ||
|
|
||
| This module provides the common configuration used by both |
There was a problem hiding this comment.
Suggested change
| This module provides the common configuration used by both | |
| This module provides the common encryption configuration used by both |
| :param logical_keystore_name: The logical name for this keystore | ||
| :param kms_key_id: The ARN of the KMS key to use | ||
| """ | ||
| # 1. Create the DynamoDb Encryption configuration for the table we will be writing to. |
There was a problem hiding this comment.
I'd add a note like "See encryption_config.py in this directory for steps to do this."
imabhichow
force-pushed
the
imabhichow/python-examples-keyrings-table
branch
from
7e40f20 to
f451e17
Compare
imabhichow
changed the title
imabhichow
force-pushed
the
imabhichow/python-examples-keyrings
branch
2 times, most recently
from
32915be to
4a6e251
Compare
Base automatically changed from
imabhichow/python-examples-keyrings
to
python-reviewed
June 3, 2025 23:31
|
Closing in-favor of New PR #1934 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.