Skip to content

fix: AWS SDK Core is not a library #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

fix: AWS SDK Core is not a library #238

merged 1 commit into from
Jun 9, 2023

Conversation

texastony
Copy link
Contributor

Issue #, if available: fix: AWS SDK Core is not a library

Description of changes: fix: AWS SDK Core is not a library

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@texastony texastony requested a review from a team as a code owner June 9, 2023 19:26
lavaleri
lavaleri approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@lavaleri lavaleri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While gradle projects can successfully build with the artifacts produced by preview-1, maven projects can not, due to the way that gradle generates the pom. We do not need to directly include aws-core within our dependencies anyway, so remove.

@texastony texastony merged commit f312e15 into main Jun 9, 2023
@texastony texastony deleted the tony/fix-aws-sdk-core-dep branch June 9, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavaleri lavaleri lavaleri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texastony @lavaleri