Skip to content

feat(EnhancedClient): Detect and Error on Ignored DynamoDB Encryption Tags #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 17, 2023

Conversation

texastony
Copy link
Contributor

@texastony texastony commented Jul 12, 2023

Issue #, if available: Detect and Error on Ignored DynamoDB Encryption Tags

Description of changes:

  • Tests using Classes that use Annotations from awssdk.enhanced.dynamodb.mapper to define nested object mapping
  • So far, the Annotations tested are:
    • @DynamoDbConvertedBy
    • @DynamoDbFlatten
    • straight up nested object with no annotation
    • Conflicting Annotations
  • Refactor DynamoDbEnhancedClientEncryption to identify some IGNORED DynamoDB Encryption Tags and throw an Exception when they are encountered.
  • Document Unhandled Shallow Ignored Configs #252 Documents two shallow configurations with ignored annotations that are NOT detected by this implementation. Only of these is of any real concern: ConflictingFlattenedBean.java

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@texastony texastony marked this pull request as ready for review July 15, 2023 00:14
@texastony texastony requested a review from a team as a code owner July 15, 2023 00:14
@texastony texastony changed the title test(EnhancedClient): Nested Objects via Annotations feat(EnhancedClient): Dectect Some Nested Objects via Annotations Jul 15, 2023
@texastony texastony changed the title feat(EnhancedClient): Dectect Some Nested Objects via Annotations feat(EnhancedClient): Detect and Error on Ignored DynamoDB Encryption Tags Jul 15, 2023
@texastony texastony dismissed seebees’s stale review July 17, 2023 20:14

Addressed Feedback

@texastony texastony merged commit e637808 into main Jul 17, 2023
@texastony texastony deleted the tony-test-nested-via-annotations branch July 17, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants