Skip to content

fix: set dist-tag to the major version to avoid overwriting latest tag #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions buildspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ batch:
image: aws/codebuild/standard:5.0
- identifier: testNodejs12
buildspec: codebuild/nodejs12.yml
env:
image: aws/codebuild/standard:5.0
- identifier: testNodejs14
buildspec: codebuild/nodejs14.yml
env:
Expand All @@ -23,9 +25,13 @@ batch:
image: aws/codebuild/standard:5.0
- identifier: testVectorsNodejs12
buildspec: codebuild/test_vectors/nodejs12.yml
env:
image: aws/codebuild/standard:5.0
- identifier: testVectorsNodejs14
buildspec: codebuild/test_vectors/nodejs14.yml
env:
image: aws/codebuild/standard:5.0
- identifier: testVectorsBrowser
buildspec: codebuild/test_vectors/browser.yml
env:
image: aws/codebuild/standard:5.0
4 changes: 3 additions & 1 deletion codebuild/release/prod-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ phases:
# This is going to use the OTP generated above and the NPM_TOKEN
# environment variable. This will only publish things that are
# missing from npm. It is therefore safe to run repeatedly.
- npx lerna publish from-package --yes --otp $OTP
# We make sure to specify a tag, otherwise the default is latest.
# This branch is no longer the latest MV so it must be avoided.
- npx lerna publish from-package --yes --otp $OTP --dist-tag '2.x'
# remove after publishing
- rm .npmrc
# Clear out the verdaccio cache so that we get the latest version
Expand Down