chore: add memory profiling in streams examples #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecorella
force-pushed
the
mem_stress_test
branch
from
bac7d27 to
e8b86e5
Compare
texastony
requested changes
Jun 20, 2022
stream_mem_stress_test/memory.ts
Outdated
| * @param filename string of file name you wish to encrypt | ||
| * @param framesize optional parameter to determine frame size; default is 4096 bytes | ||
| */ | ||
| export async function kmsEncryptStream(filename:string, framesize?:number) { |
There was a problem hiding this comment.
Nit: There should be a space b/w the variable and its type:
Suggested change
| export async function kmsEncryptStream(filename:string, framesize?:number) { | |
| export async function kmsEncryptStream(filename: string, framesize?: number) { |
stream_mem_stress_test/index.ts
Outdated
| console.log("Listening on port 3000"); | ||
| }) | ||
|
|
||
| async function readFile(filename:string, framesize?:number) { |
There was a problem hiding this comment.
Nit: Space b/w variable and it's type in signatures:
Suggested change
| async function readFile(filename:string, framesize?:number) { | |
| async function readFile(filename: string, framesize?: number) { |
stream_mem_stress_test/tsconfig.json
Outdated
Comment on lines
5
to
11
| /* Projects */ | ||
| // "incremental": true, /* Save .tsbuildinfo files to allow for incremental compilation of projects. */ | ||
| // "composite": true, /* Enable constraints that allow a TypeScript project to be used with project references. */ | ||
| // "tsBuildInfoFile": "./.tsbuildinfo", /* Specify the path to .tsbuildinfo incremental compilation file. */ | ||
| // "disableSourceOfProjectReferenceRedirect": true, /* Disable preferring source files instead of declaration files when referencing composite projects. */ | ||
| // "disableSolutionSearching": true, /* Opt a project out of multi-project reference checking when editing. */ | ||
| // "disableReferencedProjectLoad": true, /* Reduce the number of projects loaded automatically by TypeScript. */ |
There was a problem hiding this comment.
Style: Let's get rid off all this commented out stuff...
texastony
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds a directory with instructions on how to run some memory profiling examples when working with streams.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: