-
Notifications
You must be signed in to change notification settings - Fork 85
Cleanup test vector handlers module and prepare for release #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do each one of the 10 commits here provide benefit? If so, can we break this up into multiple pull requests so we can understand the changes? If not, can this be rebased into a one commit with a clear and concise commit message? |
@karlw00t They basically fall into five buckets:
I can split them out if needed, it just didn't seem like any of the changes were significant enough alone to justify five separate PRs. |
|
||
.. code:: | ||
|
||
usage: awses-full-message-encrypt [-h] --output OUTPUT --input INPUT [--human] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is awses? Google tell me it's a client for AWS ElasticSeach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shorthand for "AWS Encryption SDK" ...I forgot that ElasticSearch uses that too...any suggestions for a better shorthand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not willing to fight to hard for it. It's an internal tool, so the name collision shouldn't be too bad.
Description of changes:
1.0.0
for ready for releaseBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.