Skip to content

Cleanup test vector handlers module and prepare for release #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 12, 2018
Merged

Cleanup test vector handlers module and prepare for release #82

merged 10 commits into from
Sep 12, 2018

Conversation

mattsb42-aws
Copy link
Member

Description of changes:

  • Clean up test vector handlers sub-module
  • Add a readme for test vector handlers sub-module
  • Set test vector handlers version to 1.0.0 for ready for release

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattsb42-aws mattsb42-aws requested a review from a team September 11, 2018 23:54
@karlw00t
Copy link
Contributor

karlw00t commented Sep 12, 2018

Do each one of the 10 commits here provide benefit? If so, can we break this up into multiple pull requests so we can understand the changes? If not, can this be rebased into a one commit with a clear and concise commit message?

@mattsb42-aws
Copy link
Member Author

@karlw00t They basically fall into five buckets:

  1. Renaming the directory
  2. tweaks to support testing with older versions
  3. fleshing out tests
  4. fixing the CLI arguments
  5. setting the version

I can split them out if needed, it just didn't seem like any of the changes were significant enough alone to justify five separate PRs.


.. code::

usage: awses-full-message-encrypt [-h] --output OUTPUT --input INPUT [--human]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is awses? Google tell me it's a client for AWS ElasticSeach.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shorthand for "AWS Encryption SDK" ...I forgot that ElasticSearch uses that too...any suggestions for a better shorthand?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not willing to fight to hard for it. It's an internal tool, so the name collision shouldn't be too bad.

@karlw00t karlw00t closed this Sep 12, 2018
@karlw00t karlw00t reopened this Sep 12, 2018
@mattsb42-aws mattsb42-aws merged commit ff499ad into aws:master Sep 12, 2018
@mattsb42-aws mattsb42-aws deleted the vectors branch September 12, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants