Gg discovery #21
Gg discovery #21
Conversation
| class AWS_DISCOVERY_API GGGroup final | ||
| { | ||
| public: | ||
| GGGroup() = default; |
There was a problem hiding this comment.
They're GGGREAT!
I was going to suggest a namespace or the use of Greengrass, but then it turns out this is the nomenclature GG uses :\
| * express or implied. See the License for the specific language governing | ||
| * permissions and limitations under the License. | ||
|
|
||
| * This file is generated |
There was a problem hiding this comment.
Most files say This file is generated
Is that a copy/paste error, are these being generated from somewhere?
Or are these files just something that we aspire to generate someday
There was a problem hiding this comment.
these aren't generated.
| [](Crt::Http::HttpStream &, const Crt::Http::HttpHeader *, std::size_t) {}; | ||
| requestOptions.onIncomingHeadersBlockDone = | ||
| [callbackContext](Crt::Http::HttpStream &stream, bool) { | ||
| callbackContext->responseCode = stream.GetResponseStatusCode(); |
There was a problem hiding this comment.
[optional] this callback could be null and you could just query the response-code in the onStreamComplete() callback
There was a problem hiding this comment.
I wanted the ability to branch on it before writing to the stream. When we start generating this stuff I'll prolly revisit it.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.