assert issues

[graebm]

• Add missing #include <assert.h> to enum-handling cpp files.
• Change assert() -> AWS_ASSERT() in input-validating discovery code.
• Run formatter on discovery code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[justinboswell]

Why is this required? Why not just use AWS_ASSERT?

[graebm]

When transforming a string -> enum, if we don't recognize the string that the service returned, it does assert(0); return static_cast<JobStatus>(-1);

It's not something we want to be fatal in a release product. I asked Jonathan if he wanted the assert removed, or preserved and he wanted it preserved here.

Sorry for merging before I noticed this comment

[Kevin-Tacheny]

/home/kevin/deviceagentcpp-build/aws-iot-device-sdk-cpp-v2-prefix/src/aws-iot-device-sdk-cpp-v2/discovery/source/DiscoveryClient.cpp:32:47: error: ‘AWS_ASSERT’ was not declared in this scope

Still an issue I believe

[graebm]

This ought to work, the include chain is: DiscoveryClient.cpp -> #include <aws/crt/Types.h> -> #include <aws/common/common.h> -> #include <aws/common/assert.inl> ->#define AWS_ASSERT

Have you updated to aws-crt-cpp v0.4.0?

[Kevin-Tacheny]

Yeah I think you are correct I had some mismatch and now on to the next issue. I am still stuck on this linker error in our code: awslabs/aws-crt-cpp#26 From: graebm <[email protected]> Sent: Monday, June 3, 2019 8:04 PM To: awslabs/aws-iot-device-sdk-cpp-v2 <[email protected]> Cc: Kevin Tacheny <[email protected]>; Comment <[email protected]> Subject: Re: [awslabs/aws-iot-device-sdk-cpp-v2] assert issues (#33) ***** EXTERNAL EMAIL ***** @graebm commented on this pull request.

________________________________ In jobs/source/RejectedErrorCode.cpp<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fi.8713187.xyz%2Fawslabs%2Faws-iot-device-sdk-cpp-v2%2Fpull%2F33%23discussion_r290093313&data=01%7C01%7Ckevin.tacheny%40hitachivantara.com%7Cfef8945e018d4585e2ac08d6e8889671%7C18791e1761594f52a8d4de814ca8284a%7C0&sdata=5aj1tKGdV2Rzp4l3BSbKSLEZhhdecw%2B3AwpUVdI%2BhGY%3D&reserved=0>:

@@ -18,6 +18,8 @@

#include <aws/crt/StlAllocator.h> #include <aws/crt/StringUtils.h> +#include <assert.h> This ought to work, the include chain is: DiscoveryClient.cpp -> #include <aws/crt/Types.h> -> #include <aws/common/common.h> -> #include <aws/common/assert.inl> ->#define AWS_ASSERT Have you updated to aws-crt-cpp v0.4.0<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fi.8713187.xyz%2Fawslabs%2Faws-crt-cpp%2Freleases%2Ftag%2Fv0.4.0&data=01%7C01%7Ckevin.tacheny%40hitachivantara.com%7Cfef8945e018d4585e2ac08d6e8889671%7C18791e1761594f52a8d4de814ca8284a%7C0&sdata=mE35WK4jdT0fhQuAaNArbzwPo5%2FEYe7ZHm7bPb01kYU%3D&reserved=0>? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fi.8713187.xyz%2Fawslabs%2Faws-iot-device-sdk-cpp-v2%2Fpull%2F33%3Femail_source%3Dnotifications%26email_token%3DALMTHGWUCD3WAAZKASDOC4TPYW5RPA5CNFSM4HSL7OG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2OVMLA%23discussion_r290093313&data=01%7C01%7Ckevin.tacheny%40hitachivantara.com%7Cfef8945e018d4585e2ac08d6e8889671%7C18791e1761594f52a8d4de814ca8284a%7C0&sdata=8tyli2Q6QSxLGKt6IxCJejLGVWi6NIpPwNUyZoQ4Fyc%3D&reserved=0>, or mute the thread<https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fi.8713187.xyz%2Fnotifications%2Funsubscribe-auth%2FALMTHGVPY2VOBPZ6W73DU3DPYW5RPANCNFSM4HSL7OGQ&data=01%7C01%7Ckevin.tacheny%40hitachivantara.com%7Cfef8945e018d4585e2ac08d6e8889671%7C18791e1761594f52a8d4de814ca8284a%7C0&sdata=NDAQ%2Bkg3EzDp96ICulIkV94QBdFVeBdIplqwebvSU5s%3D&reserved=0>.