Skip to content

windowsUser addition to RunInfo #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2021
Merged

windowsUser addition to RunInfo #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8b9893
windowsUser
Nov 30, 2021
d1bba01
Formatting
bretambrose Nov 30, 2021
0b51f1b
Add secure_tunneling to formatting
bretambrose Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions eventstream_rpc/tests/include/awstest/EchoTestRpcClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,10 @@ namespace Awstest
Aws::Crt::Allocator *allocator = Aws::Crt::g_allocator) noexcept;
/**
* Connect the client to the server
* @param lifecycleHandler An interface that is called upon when lifecycle
* events relating to the connection occur.
* @param connectionConfig The configuration parameters used for establishing
* the connection.
* @return An `RpcError` that can be used to check whether the connection was
* established.
* @param lifecycleHandler An interface that is called upon when lifecycle events relating to the connection
* occur.
* @param connectionConfig The configuration parameters used for establishing the connection.
* @return An `RpcError` that can be used to check whether the connection was established.
*/
std::future<RpcError> Connect(
ConnectionLifecycleHandler &lifecycleHandler,
Expand Down
105 changes: 35 additions & 70 deletions eventstream_rpc/tests/include/awstest/EchoTestRpcModel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(Customer *) noexcept;
/* This needs to be defined so that `Customer` can be used as a key in maps.
*/
/* This needs to be defined so that `Customer` can be used as a key in maps. */
bool operator<(const Customer &) const noexcept;
static const char *MODEL_NAME;

Expand Down Expand Up @@ -157,8 +156,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(MessageData *) noexcept;
/* This needs to be defined so that `MessageData` can be used as a key in
* maps. */
/* This needs to be defined so that `MessageData` can be used as a key in maps. */
bool operator<(const MessageData &) const noexcept;
static const char *MODEL_NAME;

Expand Down Expand Up @@ -221,8 +219,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(EchoStreamingMessage *) noexcept;
/* This needs to be defined so that `EchoStreamingMessage` can be used as a
* key in maps. */
/* This needs to be defined so that `EchoStreamingMessage` can be used as a key in maps. */
bool operator<(const EchoStreamingMessage &) const noexcept;
static const char *MODEL_NAME;

Expand Down Expand Up @@ -252,8 +249,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(GetAllProductsResponse *) noexcept;
/* This needs to be defined so that `GetAllProductsResponse` can be used as a
* key in maps. */
/* This needs to be defined so that `GetAllProductsResponse` can be used as a key in maps. */
bool operator<(const GetAllProductsResponse &) const noexcept;
static const char *MODEL_NAME;

Expand All @@ -275,8 +271,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(GetAllProductsRequest *) noexcept;
/* This needs to be defined so that `GetAllProductsRequest` can be used as a
* key in maps. */
/* This needs to be defined so that `GetAllProductsRequest` can be used as a key in maps. */
bool operator<(const GetAllProductsRequest &) const noexcept;
static const char *MODEL_NAME;

Expand All @@ -299,8 +294,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(GetAllCustomersResponse *) noexcept;
/* This needs to be defined so that `GetAllCustomersResponse` can be used as a
* key in maps. */
/* This needs to be defined so that `GetAllCustomersResponse` can be used as a key in maps. */
bool operator<(const GetAllCustomersResponse &) const noexcept;
static const char *MODEL_NAME;

Expand All @@ -322,8 +316,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(GetAllCustomersRequest *) noexcept;
/* This needs to be defined so that `GetAllCustomersRequest` can be used as a
* key in maps. */
/* This needs to be defined so that `GetAllCustomersRequest` can be used as a key in maps. */
bool operator<(const GetAllCustomersRequest &) const noexcept;
static const char *MODEL_NAME;

Expand All @@ -346,8 +339,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(EchoMessageResponse *) noexcept;
/* This needs to be defined so that `EchoMessageResponse` can be used as a key
* in maps. */
/* This needs to be defined so that `EchoMessageResponse` can be used as a key in maps. */
bool operator<(const EchoMessageResponse &) const noexcept;
static const char *MODEL_NAME;

Expand All @@ -371,8 +363,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(EchoMessageRequest *) noexcept;
/* This needs to be defined so that `EchoMessageRequest` can be used as a key
* in maps. */
/* This needs to be defined so that `EchoMessageRequest` can be used as a key in maps. */
bool operator<(const EchoMessageRequest &) const noexcept;
static const char *MODEL_NAME;

Expand All @@ -394,8 +385,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(EchoStreamingResponse *) noexcept;
/* This needs to be defined so that `EchoStreamingResponse` can be used as a
* key in maps. */
/* This needs to be defined so that `EchoStreamingResponse` can be used as a key in maps. */
bool operator<(const EchoStreamingResponse &) const noexcept;
static const char *MODEL_NAME;

Expand All @@ -416,8 +406,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(EchoStreamingRequest *) noexcept;
/* This needs to be defined so that `EchoStreamingRequest` can be used as a
* key in maps. */
/* This needs to be defined so that `EchoStreamingRequest` can be used as a key in maps. */
bool operator<(const EchoStreamingRequest &) const noexcept;
static const char *MODEL_NAME;

Expand All @@ -442,8 +431,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(ServiceError *) noexcept;
/* This needs to be defined so that `ServiceError` can be used as a key in
* maps. */
/* This needs to be defined so that `ServiceError` can be used as a key in maps. */
bool operator<(const ServiceError &) const noexcept;
static const char *MODEL_NAME;

Expand All @@ -466,8 +454,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(CauseServiceErrorResponse *) noexcept;
/* This needs to be defined so that `CauseServiceErrorResponse` can be used as
* a key in maps. */
/* This needs to be defined so that `CauseServiceErrorResponse` can be used as a key in maps. */
bool operator<(const CauseServiceErrorResponse &) const noexcept;
static const char *MODEL_NAME;

Expand All @@ -488,8 +475,7 @@ namespace Awstest
Aws::Crt::StringView,
Aws::Crt::Allocator *) noexcept;
static void s_customDeleter(CauseServiceErrorRequest *) noexcept;
/* This needs to be defined so that `CauseServiceErrorRequest` can be used as
* a key in maps. */
/* This needs to be defined so that `CauseServiceErrorRequest` can be used as a key in maps. */
bool operator<(const CauseServiceErrorRequest &) const noexcept;
static const char *MODEL_NAME;

Expand Down Expand Up @@ -547,10 +533,8 @@ namespace Awstest
/**
* Used to activate a stream for the `GetAllProductsOperation`
* @param request The request used for the `GetAllProductsOperation`
* @param onMessageFlushCallback An optional callback that is invoked when the
* request is flushed.
* @return An `RpcError` that can be used to check whether the stream was
* activated.
* @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
* @return An `RpcError` that can be used to check whether the stream was activated.
*/
std::future<RpcError> Activate(
const GetAllProductsRequest &request,
Expand Down Expand Up @@ -612,10 +596,8 @@ namespace Awstest
/**
* Used to activate a stream for the `CauseServiceErrorOperation`
* @param request The request used for the `CauseServiceErrorOperation`
* @param onMessageFlushCallback An optional callback that is invoked when the
* request is flushed.
* @return An `RpcError` that can be used to check whether the stream was
* activated.
* @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
* @return An `RpcError` that can be used to check whether the stream was activated.
*/
std::future<RpcError> Activate(
const CauseServiceErrorRequest &request,
Expand All @@ -635,10 +617,8 @@ namespace Awstest
virtual void OnStreamEvent(EchoStreamingMessage *response) { (void)response; }

/**
* A callback that is invoked when an error occurs while parsing a message
* from the stream.
* @param rpcError The RPC error containing the status and possibly a CRT
* error.
* A callback that is invoked when an error occurs while parsing a message from the stream.
* @param rpcError The RPC error containing the status and possibly a CRT error.
*/
virtual bool OnStreamError(RpcError rpcError)
{
Expand All @@ -657,8 +637,7 @@ namespace Awstest
}

/**
* A callback that is invoked upon receiving ANY error response from the
* server.
* A callback that is invoked upon receiving ANY error response from the server.
* @param operationError The error message being received.
*/
virtual bool OnStreamError(OperationError *operationError)
Expand All @@ -673,8 +652,7 @@ namespace Awstest
*/
void OnStreamEvent(Aws::Crt::ScopedResource<AbstractShapeBase> response) override;
/**
* Invoked when a message is received on this continuation but results in an
* error.
* Invoked when a message is received on this continuation but results in an error.
*
* This callback can return true so that the stream is closed afterwards.
*/
Expand Down Expand Up @@ -730,12 +708,9 @@ namespace Awstest
Aws::Crt::Allocator *allocator = Aws::Crt::g_allocator) noexcept;
/**
* Used to activate a stream for the `CauseStreamServiceToErrorOperation`
* @param request The request used for the
* `CauseStreamServiceToErrorOperation`
* @param onMessageFlushCallback An optional callback that is invoked when the
* request is flushed.
* @return An `RpcError` that can be used to check whether the stream was
* activated.
* @param request The request used for the `CauseStreamServiceToErrorOperation`
* @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
* @return An `RpcError` that can be used to check whether the stream was activated.
*/
std::future<RpcError> Activate(
const EchoStreamingRequest &request,
Expand All @@ -755,10 +730,8 @@ namespace Awstest
virtual void OnStreamEvent(EchoStreamingMessage *response) { (void)response; }

/**
* A callback that is invoked when an error occurs while parsing a message
* from the stream.
* @param rpcError The RPC error containing the status and possibly a CRT
* error.
* A callback that is invoked when an error occurs while parsing a message from the stream.
* @param rpcError The RPC error containing the status and possibly a CRT error.
*/
virtual bool OnStreamError(RpcError rpcError)
{
Expand All @@ -767,8 +740,7 @@ namespace Awstest
}

/**
* A callback that is invoked upon receiving ANY error response from the
* server.
* A callback that is invoked upon receiving ANY error response from the server.
* @param operationError The error message being received.
*/
virtual bool OnStreamError(OperationError *operationError)
Expand All @@ -783,8 +755,7 @@ namespace Awstest
*/
void OnStreamEvent(Aws::Crt::ScopedResource<AbstractShapeBase> response) override;
/**
* Invoked when a message is received on this continuation but results in an
* error.
* Invoked when a message is received on this continuation but results in an error.
*
* This callback can return true so that the stream is closed afterwards.
*/
Expand Down Expand Up @@ -839,10 +810,8 @@ namespace Awstest
/**
* Used to activate a stream for the `EchoStreamMessagesOperation`
* @param request The request used for the `EchoStreamMessagesOperation`
* @param onMessageFlushCallback An optional callback that is invoked when the
* request is flushed.
* @return An `RpcError` that can be used to check whether the stream was
* activated.
* @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
* @return An `RpcError` that can be used to check whether the stream was activated.
*/
std::future<RpcError> Activate(
const EchoStreamingRequest &request,
Expand Down Expand Up @@ -904,10 +873,8 @@ namespace Awstest
/**
* Used to activate a stream for the `EchoMessageOperation`
* @param request The request used for the `EchoMessageOperation`
* @param onMessageFlushCallback An optional callback that is invoked when the
* request is flushed.
* @return An `RpcError` that can be used to check whether the stream was
* activated.
* @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
* @return An `RpcError` that can be used to check whether the stream was activated.
*/
std::future<RpcError> Activate(
const EchoMessageRequest &request,
Expand Down Expand Up @@ -969,10 +936,8 @@ namespace Awstest
/**
* Used to activate a stream for the `GetAllCustomersOperation`
* @param request The request used for the `GetAllCustomersOperation`
* @param onMessageFlushCallback An optional callback that is invoked when the
* request is flushed.
* @return An `RpcError` that can be used to check whether the stream was
* activated.
* @param onMessageFlushCallback An optional callback that is invoked when the request is flushed.
* @return An `RpcError` that can be used to check whether the stream was activated.
*/
std::future<RpcError> Activate(
const GetAllCustomersRequest &request,
Expand Down
2 changes: 1 addition & 1 deletion format-check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if NOT type $CLANG_FORMAT 2> /dev/null ; then
fi

FAIL=0
SOURCE_FILES=`find devicedefender discovery eventstream_rpc greengrass_ipc identity iotdevicecommon jobs shadow samples -type f \( -name '*.h' -o -name '*.cpp' \)`
SOURCE_FILES=`find devicedefender discovery eventstream_rpc greengrass_ipc identity iotdevicecommon jobs shadow samples secure_tunneling -type f \( -name '*.h' -o -name '*.cpp' \)`
for i in $SOURCE_FILES
do
$CLANG_FORMAT -output-replacements-xml $i | grep -c "<replacement " > /dev/null
Expand Down
10 changes: 4 additions & 6 deletions greengrass_ipc/include/aws/greengrass/GreengrassCoreIpcClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,10 @@ namespace Aws
Aws::Crt::Allocator *allocator = Aws::Crt::g_allocator) noexcept;
/**
* Connect the client to the server
* @param lifecycleHandler An interface that is called upon when lifecycle
* events relating to the connection occur.
* @param connectionConfig The configuration parameters used for establishing
* the connection.
* @return An `RpcError` that can be used to check whether the connection was
* established.
* @param lifecycleHandler An interface that is called upon when lifecycle events relating to the connection
* occur.
* @param connectionConfig The configuration parameters used for establishing the connection.
* @return An `RpcError` that can be used to check whether the connection was established.
*/
std::future<RpcError> Connect(
ConnectionLifecycleHandler &lifecycleHandler,
Expand Down
Loading