Minor modifications to the sample README file #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwistedTwigleg
force-pushed
the
SampleMarkdownAdjustment
branch
from
a61446d to
4c88442
Compare
bretambrose
approved these changes
Feb 11, 2022
samples/README.md
Outdated
| @@ -92,11 +94,28 @@ and receive. | |||
| To run the basic MQTT Pub-Sub use the following command: | |||
|
|
|||
| ``` sh | |||
| ./basic-pub-sub --endpoint <endpoint> --ca_file <path to root CA> | |||
| ./basic-pub-sub --endpoint <endpoint> --ca_file <path to root CA1> | |||
samples/README.md
Outdated
| To run using Websockets, use the following command: | ||
|
|
||
| ``` sh | ||
| ./basic-pub-sub --endpoint <endpoint> --topic <topic name> --ca_file <path to root CA1> |
There was a problem hiding this comment.
same here, just say root CA
samples/README.md
Outdated
| To run the Raw MQTT Pub-Sub sample use the following command: | ||
|
|
||
| ``` sh | ||
| ./raw-pub-sub --endpoint <endpoint> --ca_file <path to root CA1> |
samples/README.md
Outdated
| To run the Shadow sample use the following command: | ||
|
|
||
| ``` sh | ||
| ./shadow-sync --endpoint <endpoint> --ca_file <path to root CA1> |
…with the pub-sub sample
…mple, and the jobs sample
TwistedTwigleg
force-pushed
the
SampleMarkdownAdjustment
branch
from
10e3c3b to
0538e62
Compare
|
Thanks! PR merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR makes a few minor changes to the README in the
samplesfolder. The changes are:path to root CAtopath to root CA1to clarify which CA file is expected in the pub-sub sampleexitto quit the sample.quitto quit the sample.5138when used.Service Error 4 occurredand how it might indicate that the job ID may be incorrectly inputtedCurrently I am marking this PR as a draft so I can check the other samples.There's a few samples I skipped for now (PKCS#11, Fleet provisioning, Secure Tunnel, Greengrass) that I will try to come back to in the future.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.