Support mutual TLS using a certificate from a Windows cert store #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th is formatted wrong show up
Now command line parsing is broken down into a shared module so it can be reused across samples. This makes samples smaller and reduces bloat. Commit log: * Initial work on simplifying command line parsing * Continued work on simplifying command line parsing * Reformatted samples with, hopefully, the correct clang format setting this times * Another attempt at fixing clang format issues * Adjustments to CommandLineUtils and samples to allow building on Windows and Linux * Adjusted secure_tunnel sample to use AWS String instead of std string * Remove commented out namespace usage in secure_tunnel sample * Adjusted samples command line parser to show input type for commands * Minor command line parsing format fixes * Adjusted based on review feedback * Minor formatting fix * Removed const in main function in samples * Clang format fixes * Added additional command groups * Renamed AddCommonX509Commands utility function
sbSteveK
reviewed
Mar 24, 2022
sbSteveK
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to use a client certificate located in a Windows certificate store. Previously, the client certificate and private key had to be passed by filepath or file contents. With this change, certificates and keys stored on TPM devices can be used.
Add new
windows_cert_pub_subsample to show this in action.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.