Skip to content

Fix GreenGrass discovery #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Fix GreenGrass discovery #55

merged 1 commit into from
Aug 7, 2019

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Aug 7, 2019

Fixes for issue #53

I'm entering backlog tasks to do a better job on each of these fixes:

  • aws-crt-cpp and cpp-v2 should be defining their own AWS_ERROR_ codes, rather than passing AWS_ERROR_UNKNOWN whenever something goes wrong outside of c-town.
  • WithCertificateAuthority() and OverrideDefaultTrustStore() functions should have different names for whether you want to load a file or pass a in-imemory buffer. They should not rely on argument overloads.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@graebm graebm requested a review from a team August 7, 2019 20:07
@graebm graebm merged commit b1fb3a5 into master Aug 7, 2019
@graebm graebm deleted the gg-fixes branch August 7, 2019 22:58
yourslab pushed a commit to yourslab/aws-iot-device-sdk-cpp-v2 that referenced this pull request Apr 22, 2021
* Update APIs to match H1B revision
* Misc updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants