-
Notifications
You must be signed in to change notification settings - Fork 110
Update issue templates #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
--- | ||
name: "\U0001F41B Bug report" | ||
about: The issue is about a feature in the sdk not working as expected | ||
title: '' | ||
labels: bug, needs-triage | ||
assignees: '' | ||
|
||
--- | ||
|
||
Confirm by changing [ ] to [x] below to ensure that it's a bug: | ||
- [ ] I've searched for [previous similar issues](https://github.com/aws/aws-iot-device-sdk-cpp-v2/issues/) and didn't find any solution | ||
|
||
**Describe the bug** | ||
A clear and concise description of what the bug is. | ||
|
||
**Platform/OS/Device** | ||
What are you running the sdk on? | ||
|
||
**SDK version number** | ||
Example: v1.5.2 | ||
|
||
**To Reproduce (observed behavior)** | ||
Steps to reproduce the behavior (please share code) | ||
|
||
**Expected behavior** | ||
A clear and concise description of what you expected to happen. | ||
|
||
**Logs/output** | ||
If applicable, add logs or error output. | ||
|
||
*REMEMBER TO SANITIZE YOUR PERSONAL INFO* | ||
|
||
``` | ||
ApiHandle::InitializeLogging(...) | ||
``` | ||
|
||
**Additional context** | ||
Add any other context about the problem here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
--- | ||
name: "\U0001F680 Feature request" | ||
about: Suggest an idea for this project | ||
title: '' | ||
labels: feature-request, needs-triage | ||
assignees: '' | ||
|
||
--- | ||
|
||
**Is your feature request related to a problem? Please describe.** | ||
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
|
||
**Describe the solution you'd like** | ||
A clear and concise description of what you want to happen. | ||
|
||
**Describe alternatives you've considered** | ||
A clear and concise description of any alternative solutions or features you've considered. | ||
|
||
**Additional context** | ||
Add any other context or screenshots about the feature request here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
--- | ||
name: "\U0001F4AC Questions / Help" | ||
about: Make sure your question hasn't been asked before | ||
title: '' | ||
labels: guidance, needs-triage | ||
assignees: '' | ||
|
||
--- | ||
|
||
Confirm by changing [ ] to [x] below: | ||
- [ ] I've searched for [previous similar issues](https://github.com/aws/aws-iot-device-sdk-cpp-v2/issues/) and didn't find any solution | ||
|
||
**Platform/OS/Device** | ||
What are you running the sdk on? | ||
|
||
**Describe the question** |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In their code it will show up as something like
I don't know if there's a better way to communicate that the call isn't static but we don't know how they've created their ApiHandle instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea but i'm thinking this is more of a hint on how to do it rather than instructions, that should be on the readme or documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with this, and see if it confuses people. If it does, we'll write it another way until it doesn't :)