Skip to content

Fix Docs CI #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Fix Docs CI #314

merged 2 commits into from
Sep 8, 2022

Conversation

TwistedTwigleg
Copy link
Contributor

@TwistedTwigleg TwistedTwigleg commented Sep 8, 2022

Description of changes:

Fixes the documentation CI failing. Fixes this by changing a @returns to @return which was causing the issue.

There is still a LOT of errors that need to be tackled due to missing documentation in Greengrass, the Shadows client, and likely other generated models (Jobs, etc).

However, this PR will fix CI and make all the other issues warnings rather than errors until we have a chance to fully document everything.

Edit: Also fixes a missing return in the MQTT builder for custom authentication I noticed while working through the documentation.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TwistedTwigleg
Copy link
Contributor Author

Thanks! Merging into main...

@TwistedTwigleg TwistedTwigleg merged commit 472d0ec into main Sep 8, 2022
@TwistedTwigleg TwistedTwigleg deleted the FixDocCI branch September 8, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants