Merge to master - v0.9.0 #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Makefile based builder for provided runtimes
Why is this change necessary?
* provided runtimes are runtimes that are custom built with own
bootstraps etc, and its hard to determine which language it actually is.
A generic makefile based builder gives the control back to the user on
how the project needs to be built.
How does it address the issue?
* Provide a way to build for provided runtimes, which does not exist
today.
* tests: add unit, functional and integration tests
Why is this change necessary?
* Tests to ensure that the makefile based approach for provided runtimes
works.
* fix: set environment variables in addition to current
Why is this change necessary?
* On Windows, certain env variables are required for functioning of
binaries within the Makefile
How does it address the issue?
* pass current environmental variables along with new ones over to the
subprocess runner.
What side effects does this change have?
* None
* fix: does this work on windows?
* chore: add pytest logging
* fix: inject artifacts dir based on shell
Why is this change necessary?
* on powershell on windows vs git bash on windows, paths are treated
differently.
How does it address the issue?
* Dynamically change path by looking up `sh`. If present, its unix path
else its windows paths.
What side effects does this change have?
* `sh` is the check which determines which path to use. If `sh` aint
present, this will end up in breaking the workflow.
* fix: only check for shells on windows
Why is this change necessary?
* on unix, its not necessary to transform the artifacts_dir path.
How does it address the issue?
* Do a check if we are windows, before attempting to look for binaries.
What side effects does this change have?
* None.
* fix: default for env is None, not {}
* fix: address comments
* fix: pass in the manifest file as argument for make
Why is this change necessary?
* Without this, the make manifest file is always assumed to be present
with the source_dir.
How does it address the issue?
* An explicitly passed in manifest file path is now not ignored.
What side effects does this change have?
* None.
* fix: address comments
* Allow hooks to be executed NPM will not execute hooks when install is called as root. Since this is very common in scenarios where containers are involved, it makes sense to enable this flag * Fix tests Co-authored-by: Sriram Madapusi Vasudevan <[email protected]>
awood45
approved these changes
May 11, 2020
Why is this change necessary? * New minor versions of python updated in the appveyor images.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.