Skip to content

chore: remove redundant six usage #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2022

Conversation

mndeveci
Copy link
Contributor

Address issues from earlier PR: #248 (review)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from hawflau May 12, 2022 01:43
@jfuss
Copy link
Contributor

jfuss commented May 12, 2022

Can we remove six all together?

Would require removing the dep: https://github.com/aws/aws-lambda-builders/blob/develop/requirements/base.txt and from these spots as well: https://github.com/aws/aws-lambda-builders/search?q=six. Looks like the only usage is six.string_types which can be replaced by str.

@mndeveci
Copy link
Contributor Author

mndeveci commented May 13, 2022

Can we remove six all together?

Would require removing the dep: https://github.com/aws/aws-lambda-builders/blob/develop/requirements/base.txt and from these spots as well: https://github.com/aws/aws-lambda-builders/search?q=six. Looks like the only usage is six.string_types which can be replaced by str.

I followed this website to remove all six usage: https://python-future.org/compatible_idioms.html#metaclasses

I am not sure if we need to keep object as base class here;
class BaseAction(object, metaclass=_ActionMetaClass)

Let me know if that is redundant.

@mndeveci mndeveci requested a review from jfuss May 13, 2022 18:37
@jfuss
Copy link
Contributor

jfuss commented May 16, 2022

I am not sure if we need to keep object as base class here;
class BaseAction(object, metaclass=_ActionMetaClass)

I am not sure either and would rely on our tests for validation here. Without reading more deeply, this seems fine.

@mndeveci mndeveci enabled auto-merge (squash) May 18, 2022 22:50
@mndeveci mndeveci merged commit 63ed0fd into aws:develop May 30, 2022
@mndeveci mndeveci deleted the fix_comments_for_pr_248 branch May 30, 2022 16:58
calavera pushed a commit to calavera/aws-lambda-builders that referenced this pull request Jul 10, 2022
* chore: remove redundant six usage

* remove all six usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants