fix: helpful error messages when runtime mismatch for build #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an integ test that verifies this? If so, can you check the exception message there to double check and make sure the response from |
sanathkr
suggested changes
Nov 26, 2018
aws_lambda_builders/exceptions.py
Outdated
| MESSAGE = "{language} executable found in your path does not " \ | ||
| "match runtime. " \ | ||
| "\n Expected version: {required_runtime}, Found version: {found_runtime}. " \ | ||
| "\n Consider moving {required_runtime} up path hierarchy." \ |
There was a problem hiding this comment.
The "Consider..." line assumes customers do have Python somewhere else in their path. It is also not obvious how to do this for virtualenv/pyenv users. I would remove this line.
| @@ -17,6 +17,7 @@ def validate_python_cmd(required_language, required_runtime_version): | |||
| "python", | |||
| "-c", | |||
| "import sys; " | |||
| "sys.stdout.write('python' + str(sys.version_info.major) + '.' + str(sys.version_info.minor)); " | |||
| if p.returncode != 0: | ||
| raise MisMatchRuntimeError(language=required_language, | ||
| required_runtime=required_runtime) | ||
| required_runtime=required_runtime, | ||
| found_runtime=str(found_runtime.decode('utf-8'))) |
There was a problem hiding this comment.
Is the decode valid in python2.7?
There was a problem hiding this comment.
checked it with an integ test, and ran it under python2.
under python2, even if its already string and we decode. we get to unicode.
Python 2.7.10 (default, Feb 7 2017, 00:08:15)
Type "copyright", "credits" or "license" for more information.
IPython 5.8.0 -- An enhanced Interactive Python.
? -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help -> Python's own help system.
object? -> Details about 'object', use 'object??' for extra details.
In [1]: mystring="python"
In [2]: type(mystring)
Out[2]: str
In [3]: mystring.decode('utf-8')
Out[3]: u'python'
sriram-mv
force-pushed
the
runtime_error_msg
branch
from
3f64de7 to
60e89ce
Compare
sanathkr
pushed a commit
that referenced
this pull request
Nov 27, 2018
sanathkr
added a commit
that referenced
this pull request
Nov 27, 2018
)" This reverts commit 608813c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this involves following steps:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.