Skip to content

chore: Enable pylint within ruff #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aws_lambda_builders/workflows/dotnet_clipackage/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ def _is_symlink(self, file_info):
bool
A response regarding whether the ZipInfo defines a symlink or not.
"""

return (file_info.external_attr >> 28) == 0xA
symlink = 0xA
return (file_info.external_attr >> 28) == symlink

def _extract(self, file_info, output_dir, zip_ref):
"""
Expand Down
3 changes: 2 additions & 1 deletion aws_lambda_builders/workflows/python_pip/compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ def pip_import_string(python_exe):
# Pip moved its internals to an _internal module in version 10.
# In order to be compatible with version 9 which has it at at the
# top level we need to figure out the correct import path here.
if pip_major_version == 9:
pip_version_9 = 9
if pip_major_version == pip_version_9:
return "from pip import main"
# Pip changed their import structure again in 19.3
# https://github.com/pypa/pip/commit/09fd200
Expand Down
7 changes: 7 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
[tool.ruff]
line-length = 120

select = [
"E", # Pycodestyle
"F", # Pyflakes
"PL", # pylint
]
ignore = ["PLR0913"]

[tool.ruff.per-file-ignores]
"__init__.py" = ["F401", "E501"]
"aws_lambda_builders/workflow.py" = ["E501"]
Expand Down