fix: Create scratch_dir in builder.py and bump version to 0.0.4.dev1 #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanathkr
suggested changes
Dec 10, 2018
| @@ -1 +1 @@ | |||
| six~=1.11.0 | |||
| six~=1.11 | |||
tests/functional/test_cli.py
Outdated
| @@ -19,6 +19,7 @@ def setUp(self): | |||
|
|
|||
| self.source_dir = tempfile.mkdtemp() | |||
| self.artifacts_dir = tempfile.mkdtemp() | |||
| self.scratch_dir = "/tmp/scratch" | |||
There was a problem hiding this comment.
I would expect that to fail in appveyor through.
sanathkr
suggested changes
Dec 10, 2018
tests/functional/test_builder.py
Outdated
| @@ -19,6 +19,7 @@ def setUp(self): | |||
|
|
|||
| self.source_dir = tempfile.mkdtemp() | |||
| self.artifacts_dir = tempfile.mkdtemp() | |||
| self.scratch_dir = "/tmp/scratch" | |||
There was a problem hiding this comment.
windows?
You should really use a tempfile here instead of /tmp/scratch because the test will be creating this directory.
You can use something like os.path.join(tempfile.mkdtemp(), "scratch") to save yourself the headache of finding a temp filename yourself
There was a problem hiding this comment.
I didn't think of this. I first thought of doing tempfile.mkdtemp() but that creates the directory, which is why I did what I did. Will update.
sanathkr
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Create the scratch directory in the builder so each workflow can safely assume the directory is available to use.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.