Fix issue of syncing CF template when all LambdaFunctions are removed. #1258
+50
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
force-pushed
the
normj/annotations-fix-delete
branch
from
9687ead to
ac8d502
Compare
ganeshnj
suggested changes
Aug 1, 2022
| public bool DoesCloudFormationTemplateExist(string projectRootDirectory) | ||
| { | ||
| var templateAbsolutePath = DetermineCloudFormationTemplatePath(projectRootDirectory); | ||
| return File.Exists(templateAbsolutePath); |
There was a problem hiding this comment.
should use IFileManager wrapper here.
Suggested change
| return File.Exists(templateAbsolutePath); | |
| return _fileManager.Exists(templateAbsolutePath); |
normj
force-pushed
the
normj/annotations-fix-delete
branch
from
ac8d502 to
2218656
Compare
ganeshnj
approved these changes
Aug 1, 2022
philasmar
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix an issue when all of the remaining
LambdaFunctionare removed from the project the CF template is not synced leaving the Lambda functions defined in the template.The fix has the following changes:
LambdaFunctionbut since there might not be anyLambdaFunctionit was moved to the syntax visitor and where it can be computed on the first class that was found.LambdaFunctionwhich caused the bug to only short circuit if the project directory was not calculated. That would happen if there are no classes in the project.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.