fix: fix error thrown when template includes intrinsic function #1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96malhar
reviewed
Jun 20, 2023
There was a problem hiding this comment.
Can you also update the unit tests in YamlWriterTests.cs to verify that YAML blobs with intrinsic functions are parsed correctly?
philasmar
force-pushed
the
asmarp/ignore-intrinsic-function
branch
from
f1d3449 to
39620bb
Compare
I added an intrinsic function to some of the tests, but it doesn't apply to all since this PR is not introducing a fix to parsing intrinsic functions. The PR is updating the Lambda Annotations code so workaround this limitation. |
philasmar
force-pushed
the
asmarp/ignore-intrinsic-function
branch
from
39620bb to
4a4480d
Compare
philasmar
force-pushed
the
asmarp/ignore-intrinsic-function
branch
from
4a4480d to
f78d1b4
Compare
normj
requested changes
Jun 22, 2023
Libraries/src/Amazon.Lambda.Annotations.SourceGenerator/Writers/CloudFormationWriter.cs
Outdated
Show resolved
Hide resolved
philasmar
force-pushed
the
asmarp/ignore-intrinsic-function
branch
from
f78d1b4 to
ccc3bdc
Compare
normj
approved these changes
Jun 22, 2023
Libraries/src/Amazon.Lambda.Annotations.SourceGenerator/Writers/CloudFormationWriter.cs
Outdated
Show resolved
Hide resolved
96malhar
approved these changes
Jun 22, 2023
ashovlin
approved these changes
Jun 22, 2023
philasmar
force-pushed
the
asmarp/ignore-intrinsic-function
branch
from
ccc3bdc to
783f70d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
DOTNET-4300, #1340
Description of changes:
An error was thrown when a short form intrinsic function appears in a CloudFormation template. This error was due to an invalid casting to
Dictionary<string, object>. Modifying this to aDictionary<string, YamlMappingNode>for YAML templates fixed the issue.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.