template/docs: change .NET build base-image from 8.0-bullseye-slim -> 8.0 #1677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
requested changes
Feb 24, 2024
...lueprintDefinitions/vs2022/AspNetCoreWebAPI-Image/template/src/BlueprintBaseName.1/Readme.md
Outdated
Show resolved
Hide resolved
cdschneider
changed the title
normj
approved these changes
Feb 26, 2024
jnunn-aws
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
n/a
Description of changes:
The
serverless.AspNetCoreWebAPItemplate includes documentation for how to author a container-image (using a multi-stage build). TheREADME.mdincludes exampleDockerfilecode that can be misleading because thebuildbase image uses an8.0-bullseye-slimtag, where this tag does not actually exist (discussion/question/answer here: dotnet/dotnet-docker#5002).Based on Microsoft's Supported Platforms documentation the proper tag to use should be
8.0-bookworm-slimBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.