1728 - Enhance/Fix ByteArrayConverter to support base64 deserialization of byte[] #1736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 1728
Description of changes:
Add support for deserializing a base64
string
to abyte[]
.If the token is a string, assume it is base64 encoded string and get bytes.
Otherwise, continue to do what it did before.
I added xunit tests for both conditions. To ensure my desired behavior works, and the existing behavior also works. I'm not strong in xunit, so if there are tweaks needed, please advise. Also wasn't sure where the best home/project for those tests might be.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.