-
Notifications
You must be signed in to change notification settings - Fork 491
Handle error conditions from Lambda function in Runtime API #1953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -99,24 +99,35 @@ public static ApiGatewayEmulatorProcess Startup(RunCommandSettings settings, Can | |
using var lambdaClient = CreateLambdaServiceClient(routeConfig, settings); | ||
var response = await lambdaClient.InvokeAsync(invokeRequest); | ||
|
||
if (response.FunctionError != null) | ||
if (response.FunctionError == null) // response is successful | ||
{ | ||
// TODO: Mimic API Gateway's behavior when Lambda function has an exception during invocation. | ||
context.Response.StatusCode = 500; | ||
return; | ||
} | ||
|
||
// Convert API Gateway response object returned from Lambda to ASP.NET Core response. | ||
if (settings.ApiGatewayEmulatorMode.Equals(ApiGatewayEmulatorMode.HttpV2)) | ||
{ | ||
var lambdaResponse = response.ToApiGatewayHttpApiV2ProxyResponse(); | ||
await lambdaResponse.ToHttpResponseAsync(context); | ||
if (settings.ApiGatewayEmulatorMode.Equals(ApiGatewayEmulatorMode.HttpV2)) | ||
{ | ||
var lambdaResponse = response.ToApiGatewayHttpApiV2ProxyResponse(); | ||
await lambdaResponse.ToHttpResponseAsync(context); | ||
} | ||
else | ||
{ | ||
var lambdaResponse = response.ToApiGatewayProxyResponse(settings.ApiGatewayEmulatorMode.Value); | ||
await lambdaResponse.ToHttpResponseAsync(context, settings.ApiGatewayEmulatorMode.Value); | ||
} | ||
} | ||
else | ||
{ | ||
var lambdaResponse = response.ToApiGatewayProxyResponse(settings.ApiGatewayEmulatorMode.Value); | ||
await lambdaResponse.ToHttpResponseAsync(context, settings.ApiGatewayEmulatorMode.Value); | ||
// For function errors, api gateway just displays them as an internal server error, so we convert them to the correct error response here. | ||
|
||
if (settings.ApiGatewayEmulatorMode.Equals(ApiGatewayEmulatorMode.HttpV2)) | ||
{ | ||
var lambdaResponse = InvokeResponseExtensions.ToHttpApiV2ErrorResponse(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I kept these function (ToErrorResponse) inside the extensions class because I wasn't sure else where to put them, even though they really arent being used as extensions. I figured it's fine for now but if anyone has better ideas let me know. |
||
await lambdaResponse.ToHttpResponseAsync(context); | ||
} | ||
else | ||
{ | ||
var lambdaResponse = InvokeResponseExtensions.ToApiGatewayErrorResponse(settings.ApiGatewayEmulatorMode.Value); | ||
await lambdaResponse.ToHttpResponseAsync(context, settings.ApiGatewayEmulatorMode.Value); | ||
} | ||
} | ||
|
||
}); | ||
|
||
var runTask = app.RunAsync(cancellationToken); | ||
|
6 changes: 6 additions & 0 deletions
6
Tools/LambdaTestTool-v2/src/Amazon.Lambda.TestTool/Properties/AssemblyInfo.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
using System.Runtime.CompilerServices; | ||
|
||
[assembly: InternalsVisibleTo("Amazon.Lambda.TestTool.UnitTests")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just put this in its own function so i can re-use it