Skip to content

Update ApiGatewayEmulatorProcessTests #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update ApiGatewayEmulatorProcessTests #1955

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 68 additions & 19 deletions ...stTool-v2/tests/Amazon.Lambda.TestTool.IntegrationTests/ApiGatewayEmulatorProcessTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0

using System.Collections.Concurrent;
using System.Diagnostics;
using System.Net;
using System.Net.Sockets;
using System.Text;
using Amazon.Lambda.TestTool.Commands;
using Amazon.Lambda.TestTool.Commands.Settings;
Expand All @@ -22,6 +24,8 @@ public class ApiGatewayEmulatorProcessTests : IAsyncDisposable
private readonly Mock<IToolInteractiveService> _mockInteractiveService = new Mock<IToolInteractiveService>();
private readonly Mock<IRemainingArguments> _mockRemainingArgs = new Mock<IRemainingArguments>();
private readonly ITestOutputHelper _testOutputHelper;
private readonly ConcurrentQueue<string> _logMessages = new ConcurrentQueue<string>();
private readonly SemaphoreSlim _logSemaphore = new SemaphoreSlim(1, 1);
private Process? _lambdaProcess;

public ApiGatewayEmulatorProcessTests(ITestOutputHelper testOutputHelper)
Expand All @@ -32,8 +36,8 @@ public ApiGatewayEmulatorProcessTests(ITestOutputHelper testOutputHelper)
[Fact]
public async Task TestLambdaToUpperV2()
{
var lambdaPort = 6012;
var apiGatewayPort = 6013;
var (lambdaPort, apiGatewayPort) = await GetFreePorts();

var testProjectDir = Path.GetFullPath("../../../../../testapps");
var config = new TestConfig
{
Expand Down Expand Up @@ -67,8 +71,8 @@ public async Task TestLambdaToUpperV2()
[Fact]
public async Task TestLambdaToUpperRest()
{
var lambdaPort = 6010;
var apiGatewayPort = 6011;
var (lambdaPort, apiGatewayPort) = await GetFreePorts();

var testProjectDir = Path.GetFullPath("../../../../../testapps");
var config = new TestConfig
{
Expand Down Expand Up @@ -102,8 +106,9 @@ public async Task TestLambdaToUpperRest()
[Fact]
public async Task TestLambdaToUpperV1()
{
var lambdaPort = 6008;
var apiGatewayPort = 6009;
var (lambdaPort, apiGatewayPort) = await GetFreePorts();


var testProjectDir = Path.GetFullPath("../../../../../testapps");
var config = new TestConfig
{
Expand Down Expand Up @@ -137,8 +142,9 @@ public async Task TestLambdaToUpperV1()
[Fact]
public async Task TestLambdaBinaryResponse()
{
var lambdaPort = 6006;
var apiGatewayPort = 6007;
var (lambdaPort, apiGatewayPort) = await GetFreePorts();


var testProjectDir = Path.GetFullPath("../../../../../testapps");
var config = new TestConfig
{
Expand Down Expand Up @@ -178,8 +184,8 @@ public async Task TestLambdaBinaryResponse()
[Fact]
public async Task TestLambdaReturnString()
{
var lambdaPort = 6004;
var apiGatewayPort = 6005;
var (lambdaPort, apiGatewayPort) = await GetFreePorts();

var testProjectDir = Path.GetFullPath("../../../../../testapps");
var config = new TestConfig
{
Expand Down Expand Up @@ -227,8 +233,8 @@ public async Task TestLambdaWithNullEndpoint()

try
{
const int lambdaPort = 5060;
const int apiGatewayPort = 5061;
var (lambdaPort, apiGatewayPort) = await GetFreePorts();

StartTestToolProcessWithNullEndpoint(ApiGatewayEmulatorMode.HttpV2, lambdaPort, apiGatewayPort, config, cancellationTokenSource);
await WaitForGatewayHealthCheck(apiGatewayPort);
await StartLambdaProcess(config, lambdaPort);
Expand Down Expand Up @@ -302,6 +308,34 @@ private void StartTestToolProcess(ApiGatewayEmulatorMode apiGatewayMode, TestCon
_ = command.ExecuteAsync(context, settings, cancellationTokenSource);
}

private async Task<(int lambdaPort, int apiGatewayPort)> GetFreePorts()
{
// Get two different ports
var lambdaPort = GetFreePort();
int apiGatewayPort;
do
{
apiGatewayPort = GetFreePort();
} while (apiGatewayPort == lambdaPort);

return (lambdaPort, apiGatewayPort);
}

private int GetFreePort()
{
var listener = new TcpListener(IPAddress.Loopback, 0);
try
{
listener.Start();
var port = ((IPEndPoint)listener.LocalEndpoint).Port;
return port;
}
finally
{
listener.Stop();
}
}

private async Task StartLambdaProcess(TestConfig config, int lambdaPort)
{
// Build the project
Expand Down Expand Up @@ -339,13 +373,13 @@ private async Task StartLambdaProcess(TestConfig config, int lambdaPort)

private void ConfigureProcessLogging(Process process, string prefix)
{
process.OutputDataReceived += (_, e) =>
process.OutputDataReceived += async (_, e) =>
{
if (e.Data != null) LogMessage($"{prefix}: {e.Data}");
if (e.Data != null) await LogMessage($"{prefix}: {e.Data}");
};
process.ErrorDataReceived += (_, e) =>
process.ErrorDataReceived += async (_, e) =>
{
if (e.Data != null) LogMessage($"{prefix} Error: {e.Data}");
if (e.Data != null) await LogMessage($"{prefix} Error: {e.Data}");
};
process.BeginOutputReadLine();
process.BeginErrorReadLine();
Expand Down Expand Up @@ -406,10 +440,18 @@ private async Task WaitForGatewayHealthCheck(int apiGatewayPort)
throw new TimeoutException("API Gateway failed to start within timeout period");
}

private void LogMessage(string message)
private async Task LogMessage(string message)
{
Console.WriteLine(message);
_testOutputHelper.WriteLine(message);
await _logSemaphore.WaitAsync();
try
{
Console.WriteLine(message); // Still write to console for debugging
_logMessages.Enqueue(message);
}
finally
{
_logSemaphore.Release();
}
}

private async Task CleanupProcesses()
Expand All @@ -435,6 +477,13 @@ private async Task CleanupProcesses()

public async ValueTask DisposeAsync()
{
// Write all queued messages before disposing
while (_logMessages.TryDequeue(out var message))
{
_testOutputHelper.WriteLine(message);
}

await CleanupProcesses();
_logSemaphore.Dispose();
}
}
Loading