-
Notifications
You must be signed in to change notification settings - Fork 32
Version 3 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 3 #38
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,9 @@ | ||
#! /usr/bin/env ruby | ||
|
||
# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
|
||
# frozen_string_literal: true | ||
|
||
require 'bundler/setup' | ||
require_relative '../lib/aws_lambda_ric/bootstrap' | ||
require_relative '../lib/aws_lambda_ric' | ||
|
||
lambda_ric = AwsLambdaRIC::Bootstrap.new | ||
|
||
Bootstrap.start | ||
lambda_ric.start |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
|
||
version: 0.2 | ||
|
||
env: | ||
shell: bash | ||
|
||
phases: | ||
install: | ||
commands: | ||
- docker logout public.ecr.aws | ||
- docker pull public.ecr.aws/amazonlinux/amazonlinux:2 | ||
|
||
pre_build: | ||
commands: | ||
- mkdir -p "${OUT_DIR:-build-artifacts}" | ||
|
||
build: | ||
commands: | ||
- make build-all OUT_DIR="${OUT_DIR:-build-artifacts}" | ||
|
||
artifacts: | ||
files: | ||
- "build-artifacts/**" |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason to use 3.1 over 3.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was what was internal. My focus here was to do the syncing and do incremental upgrades on top later. I also wanted to discuss a release strategy. Typically ruby gems support multiple versions of ruby like this gem seemed to do. I think for lambdas use case, it may be simpler to release minor versions corresponding to the ruby version and support a singular ruby minor version. E.g. gem version 3.4 supports ruby 3.4 only. This may work for lambda because you deploy a single ruby version runtime using this gem correct?