Fix Java 11 build

[zoewangg]

Description

• Fix failed test with Java 11
  See Mac Java 11 NettyNioAsyncHttpClientSpiVerificationTest Failed #1038

Root cause is an known issue in wiremock with Java 11 wiremock/wiremock#1009. Changed CONNECTION_RESET_BY_PEER to RANDOM_DATA_THEN_CLOSE instead to fix the test.

• Fix false positive bugs reported by spotbugs

• Update travis script to run java 11 for obvious reasons.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed
• A short description of the change has been added to the CHANGELOG
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[dagnir]

minor: How much extra logging will this create? Just worried about the log size in Travis

[zoewangg]

Good point, will change it to OFF

[zoewangg]

The test is happy but spotbugs failed :(

[codecov-io]

Codecov Report

Merging #1139 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #1139      +/-   ##
============================================
- Coverage     58.82%   58.75%   -0.07%     
+ Complexity     4566     4556      -10     
============================================
  Files           742      742              
  Lines         22895    22941      +46     
  Branches       1707     1713       +6     
============================================
+ Hits          13468    13480      +12     
- Misses         8735     8772      +37     
+ Partials        692      689       -3

Impacted Files	Coverage Δ	Complexity Δ
.../interceptor/ClasspathInterceptorChainFactory.java	10% <0%> (-0.42%)	5 <0> (ø)
.../netty/internal/UnusedChannelExceptionHandler.java	18.75% <0%> (-18.75%)	2% <0%> (-1%)
...nio/netty/internal/OldConnectionReaperHandler.java	81.81% <0%> (-9.1%)	12% <0%> (-3%)
...tomization/CodegenCustomizationProcessorChain.java	81.81% <0%> (-8.19%)	5% <0%> (ø)
...on/awssdk/protocols/ion/AwsIonProtocolFactory.java	72.72% <0%> (-5.06%)	5% <0%> (ø)
...wssdk/http/nio/netty/internal/ResponseHandler.java	63.05% <0%> (-4.69%)	15% <0%> (-4%)
...ftware/amazon/awssdk/codegen/internal/Jackson.java	59.09% <0%> (-2.82%)	3% <0%> (ø)
.../software/amazon/awssdk/core/sync/RequestBody.java	75% <0%> (-2.78%)	13% <0%> (ø)
...on/awssdk/codegen/internal/DocumentationUtils.java	74.19% <0%> (-2.48%)	16% <0%> (ø)
...k/codegen/poet/client/specs/QueryProtocolSpec.java	66% <0%> (-1.35%)	8% <0%> (ø)
... and 24 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b780909...98be964. Read the comment docs.

[dagnir]

Why does this need the BOM?

[zoewangg]

This is something I tried to make it build with CodeBuild on this module. After this change, this module can be built successfully but other module fails of the same reason "Connection Reset". I can remove this.

[dagnir]

Ah okay. Yeah let's remove it for now, this module shouldn't need it.