Fix SslHandler in Netty client #1184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1184 +/- ##
============================================
- Coverage 58.98% 58.98% -0.01%
- Complexity 4594 4595 +1
============================================
Files 744 744
Lines 23020 23027 +7
Branches 1721 1721
============================================
+ Hits 13579 13583 +4
- Misses 8755 8756 +1
- Partials 686 688 +2
Continue to review full report at Codecov.
|
dagnir
approved these changes
Apr 3, 2019
|
|
||
| public ChannelPipelineInitializer(Protocol protocol, | ||
| SslContext sslCtx, | ||
| long clientMaxStreams, | ||
| AtomicReference<ChannelPool> channelPoolRef, | ||
| NettyConfiguration configuration) { | ||
| NettyConfiguration configuration, | ||
| URI key) { |
There was a problem hiding this comment.
nit: poolKey might be a little more descriptive
|
|
||
| CreateAppResponse response = pinpointAsyncClient.createApp(b -> b.createApplicationRequest(r -> r.name(APP_NAME))).join(); | ||
|
|
||
| appId = response.applicationResponse().id(); |
There was a problem hiding this comment.
Is it necessary to create an app? Would doing a list operation be sufficient (to avoid creating any resources)?
There was a problem hiding this comment.
Nope, updated to use getApps instead
zoewangg
force-pushed
the
zoewang-pinpointAsync
branch
from
99cd0d4 to
b09720e
Compare
spfink
approved these changes
Apr 3, 2019
|
|
||
| public ChannelPipelineInitializer(Protocol protocol, | ||
| SslContext sslCtx, | ||
| long clientMaxStreams, | ||
| AtomicReference<ChannelPool> channelPoolRef, | ||
| NettyConfiguration configuration) { | ||
| NettyConfiguration configuration, | ||
| URI poorKey) { |
There was a problem hiding this comment.
Oops. Good catch! Fixed.
| */ | ||
| private void configureSslEngine(SSLEngine sslEngine) { | ||
| SSLParameters sslParameters = sslEngine.getSSLParameters(); | ||
| sslParameters.setEndpointIdentificationAlgorithm("HTTPS"); |
There was a problem hiding this comment.
How in the world is this not the default...
…sed the requests to fail of handshake_failure in some services.
zoewangg
force-pushed
the
zoewang-pinpointAsync
branch
from
b09720e to
92fcb55
Compare
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Feb 5, 2021
Recover the correct model for ec2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug where SNI was not enabled in Netty NIO Async Client for TLS and caused the requests to fail of handshake_failure in some services.
Motivation and Context
See #1171
Testing
Added integ tests.
Running the whole integ tests suites now.All integ tests passedScreenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense