Skip to content

Improved error messaging when a connection is closed. Fixes #1260. #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2019

Conversation

millems
Copy link
Contributor

@millems millems commented May 22, 2019

No description provided.

@millems millems force-pushed the millem/improve-error-messaging branch from c4ca420 to 0b812c6 Compare May 22, 2019 21:18
@millems millems force-pushed the millem/improve-error-messaging branch from 0b812c6 to 452e478 Compare May 22, 2019 21:19
@codecov-io
Copy link

codecov-io commented May 22, 2019

Codecov Report

Merging #1263 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1263      +/-   ##
============================================
- Coverage     70.55%   70.53%   -0.02%     
  Complexity      188      188              
============================================
  Files           776      776              
  Lines         24021    24027       +6     
  Branches       1789     1795       +6     
============================================
  Hits          16948    16948              
- Misses         6285     6294       +9     
+ Partials        788      785       -3
Flag Coverage Δ Complexity Δ
#unittests 70.53% <0%> (-0.02%) 188 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
.../http/nio/netty/internal/NettyRequestExecutor.java 63.82% <0%> (-1.04%) 0 <0> (ø)
...o/netty/internal/utils/BetterFixedChannelPool.java 54.14% <0%> (-4.98%) 0% <0%> (ø)
...ware/amazon/awssdk/utils/cache/CachedSupplier.java 87.8% <0%> (-2.44%) 0% <0%> (ø)
...on/awssdk/services/kinesis/KinesisRetryPolicy.java 85.71% <0%> (ø) 0% <0%> (ø) ⬇️
...ttp/pipeline/stages/MakeAsyncHttpRequestStage.java 96.8% <0%> (+0.03%) 0% <0%> (ø) ⬇️
.../software/amazon/awssdk/codegen/AddOperations.java 85.33% <0%> (+0.19%) 0% <0%> (ø) ⬇️
...ssdk/auth/credentials/HttpCredentialsProvider.java 58.33% <0%> (+0.58%) 0% <0%> (ø) ⬇️
...signer/internal/AwsChunkedEncodingInputStream.java 47.29% <0%> (+0.67%) 0% <0%> (ø) ⬇️
...mazon/awssdk/core/internal/retry/RetryHandler.java 90.9% <0%> (+2.27%) 0% <0%> (ø) ⬇️
...p/nio/netty/internal/HealthCheckedChannelPool.java 90.47% <0%> (+4.76%) 0% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4cd90b...419910e. Read the comment docs.

@dagnir dagnir merged commit 6411db3 into master Jul 8, 2019
@millems millems deleted the millem/improve-error-messaging branch March 17, 2020 23:35
aws-sdk-java-automation added a commit that referenced this pull request Apr 5, 2021
…9953147b6

Pull request: release <- staging/f10bfca3-9009-4e14-a8bd-c849953147b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants