Skip to content

Fixed issue where specifying a custom presigning time causes a runtime exception. #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2019

Conversation

millems
Copy link
Contributor

@millems millems commented Jun 26, 2019

No description provided.

@millems millems merged commit e145459 into master Jun 26, 2019
@millems millems deleted the millem/fix-presigner branch June 26, 2019 20:07
@codecov-io
Copy link

Codecov Report

Merging #1310 into master will increase coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1310      +/-   ##
============================================
+ Coverage     70.53%   70.57%   +0.03%     
  Complexity      188      188              
============================================
  Files           776      776              
  Lines         24038    24039       +1     
  Branches       1797     1797              
============================================
+ Hits          16956    16966      +10     
+ Misses         6297     6290       -7     
+ Partials        785      783       -2
Flag Coverage Δ Complexity Δ
#unittests 70.57% <85.71%> (+0.03%) 188 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...wssdk/auth/signer/internal/AbstractAws4Signer.java 88.19% <85.71%> (-0.56%) 0 <0> (ø)
.../http/nio/netty/internal/NettyRequestExecutor.java 70.27% <0%> (+5.4%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9cc310...1573acd. Read the comment docs.

@millems millems mentioned this pull request Jun 26, 2019
aws-sdk-java-automation added a commit that referenced this pull request Apr 23, 2021
…c249b7832

Pull request: release <- staging/0f785f82-4afa-4e79-be53-6efc249b7832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants