Gracefully handle GOAWAY #1479
Merged
Gracefully handle GOAWAY #1479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
============================================
+ Coverage 73.81% 74.43% +0.61%
Complexity 720 720
============================================
Files 850 852 +2
Lines 26160 26175 +15
Branches 2018 2018
============================================
+ Hits 19311 19483 +172
+ Misses 5974 5803 -171
- Partials 875 889 +14
Continue to review full report at Codecov.
|
millems
reviewed
Oct 21, 2019
| endpointDriver.channels.forEach(ch -> endpointDriver.goAway(ch, 1)); | ||
|
|
||
| // Need to give a chance for the streams to get closed | ||
| Thread.sleep(1000); |
There was a problem hiding this comment.
Have we run this enough to be convinced it isn't flaky?
There was a problem hiding this comment.
1s is a pretty long time to close 2 connections so it should be fine
Comment on lines
+121
to
+133
| if (streamId == 3) { | ||
| stream3Received.complete(null); | ||
| } | ||
|
|
||
| if (streamId < 5) { | ||
| Http2Headers outboundHeaders = new DefaultHttp2Headers() | ||
| .status("200") | ||
| .add("content-type", "text/plain") | ||
| .addInt("content-length", getPayload.length); | ||
|
|
||
| frameWriter().writeHeaders(ctx, streamId, outboundHeaders, 0, false, ctx.newPromise()); | ||
| ctx.flush(); | ||
| } |
There was a problem hiding this comment.
I'm probably missing something. Why 3 and 5 when there's only 2 requests?
There was a problem hiding this comment.
The client always initiates streams using odd numbers. The first stream used to establish the H2 stream is 1, so the next two are 3 and 5.
| @@ -62,7 +74,7 @@ public void closeWaitsForConnectionToBeReleasedBeforeClosingConnectionPool() thr | |||
| Promise<Void> releasePromise = Mockito.spy(new DefaultPromise<>(loopGroup.next())); | |||
| Mockito.doCallRealMethod().when(releasePromise).await(); | |||
| releasePromise.setSuccess(null); | |||
| Mockito.when(connectionPool.release(Mockito.eq(channel))).thenReturn(releasePromise); | |||
| Mockito.when(connectionPool.release(eq(channel))).thenReturn(releasePromise); | |||
There was a problem hiding this comment.
Do we need this file, still?
- Ensure that the GOAWAY exception is fired within each child channel's event loop to ensure correct ordering - Fix off-by-one error in MultiplexedChannelRecord - Add tests using a minimal H2 endpoint implementation - Remove test-server module since it's no longer needed
dagnir
force-pushed
the
dongie/respect-goaway-fix
branch
from
5acb3e0 to
4e4c411
Compare
millems
approved these changes
Oct 21, 2019
Comment on lines
+121
to
+133
| if (streamId == 3) { | ||
| stream3Received.complete(null); | ||
| } | ||
|
|
||
| if (streamId < 5) { | ||
| Http2Headers outboundHeaders = new DefaultHttp2Headers() | ||
| .status("200") | ||
| .add("content-type", "text/plain") | ||
| .addInt("content-length", getPayload.length); | ||
|
|
||
| frameWriter().writeHeaders(ctx, streamId, outboundHeaders, 0, false, ctx.newPromise()); | ||
| ctx.flush(); | ||
| } |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jun 17, 2021
…7dad42406 Pull request: release <- staging/285aae68-af2e-4c5c-a25a-81d7dad42406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that the GOAWAY exception is fired within each child channel's event
loop to ensure correct ordering
Fix off-by-one error in MultiplexedChannelRecord
Add tests using a minimal H2 endpoint implementation
Remove test-server module since it's no longer needed
Motivation and Context
Bug fix.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense