Skip to content

Update UnusedChannelExceptionHandler to extend inboundHandler #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2019

Conversation

zoewangg
Copy link
Contributor

Description

Update UnusedChannelExceptionHandler to extend inboundHandler because

exceptionOccurred is deprecated in ChannelHandlerAdapter and it should be handled in ChannelInboundHandler now.

https://netty.io/4.1/api/io/netty/channel/ChannelHandler.html#exceptionCaught-io.netty.channel.ChannelHandlerContext-java.lang.Throwable-

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-io
Copy link

Codecov Report

Merging #1532 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1532      +/-   ##
============================================
+ Coverage     74.89%   74.96%   +0.06%     
  Complexity      767      767              
============================================
  Files           871      871              
  Lines         26820    26872      +52     
  Branches       2061     2077      +16     
============================================
+ Hits          20088    20145      +57     
+ Misses         5811     5810       -1     
+ Partials        921      917       -4
Flag Coverage Δ Complexity Δ
#unittests 74.96% <ø> (+0.06%) 767 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
.../netty/internal/UnusedChannelExceptionHandler.java 88.23% <ø> (ø) 0 <0> (ø) ⬇️
...tomization/CodegenCustomizationProcessorChain.java 81.81% <0%> (-8.19%) 0% <0%> (ø)
...on/awssdk/protocols/ion/AwsIonProtocolFactory.java 72.72% <0%> (-5.06%) 0% <0%> (ø)
.../software/amazon/awssdk/core/sync/RequestBody.java 89.28% <0%> (-3.31%) 0% <0%> (ø)
...ftware/amazon/awssdk/codegen/internal/Jackson.java 59.09% <0%> (-2.82%) 0% <0%> (ø)
...on/awssdk/codegen/internal/DocumentationUtils.java 74.19% <0%> (-2.48%) 0% <0%> (ø)
...db/mappingclient/extensions/WriteModification.java 52% <0%> (-2.17%) 5% <0%> (ø)
...amodb/mappingclient/operations/ConditionCheck.java 41.66% <0%> (-1.2%) 3% <0%> (ø)
...ty/internal/http2/Http2MultiplexedChannelPool.java 74.28% <0%> (-1.08%) 0% <0%> (ø)
...mappingclient/operations/GlobalSecondaryIndex.java 29.03% <0%> (-0.97%) 5% <0%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b697abd...d021843. Read the comment docs.

@zoewangg zoewangg merged commit 11d6e17 into master Dec 9, 2019
@zoewangg zoewangg deleted the zoewang-updateDeprecatedApi branch December 9, 2019 23:22
aws-sdk-java-automation added a commit that referenced this pull request Jul 12, 2021
…5c4d9f36e

Pull request: release <- staging/1abed839-904b-49c4-9f5a-bba5c4d9f36e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants