Skip to content

Add support for Asctime date format #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MattFromGer
Copy link

Description

Add support for ANSI C Asctime date format

Motivation and Context

Testing

I included tests for formatting & parsing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
Copy link
Contributor

dagnir commented Apr 7, 2021

Hi @MattFromGer I'm going through the PR backlog. What is the motivation for this feature?

@MattFromGer
Copy link
Author

Hey @dagnir, the Amazon Gift Card Incentives API is using this format. I've set up a client using the SDK here. With this PR dates could be automatically parsed.
Maybe out of scope for you guys, and more of a "nice to have" sort of thing.

@dagnir
Copy link
Contributor

dagnir commented Apr 8, 2021

Ah okay thanks for the context 😄 The change itself looks fine but yes, this falls in more in the nice to have category for now since no included services use this format.

If a service starts using this type in the future, we'll need to make sure the other SDKs behave the same way w.r.t to this type. I'm going to go ahead and close this in the mean time, but it can be revived once we have a need to add support for it!

PS. I think it's really awesome to see you're using the SDK code generator to generate a custom SDK!

@dagnir dagnir closed this Apr 8, 2021
aws-sdk-java-automation pushed a commit that referenced this pull request Jul 19, 2021
Create javadoc jars for Jackson shaded libs
@MattFromGer MattFromGer deleted the feat/dateformat-asctime branch August 9, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants