Skip to content

Add support for tagging builder in createMultipartUploadRequest #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Jan 8, 2020

Description

Add support for tagging builder in createMultipartUploadRequest.

I've verified there are no other existing models that have Tagging field

Motivation and Context

See #1440

Testing

Added integ tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #1581 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1581      +/-   ##
============================================
+ Coverage     75.54%   75.55%   +<.01%     
  Complexity      638      638              
============================================
  Files           896      896              
  Lines         28064    28064              
  Branches       2214     2214              
============================================
+ Hits          21202    21203       +1     
+ Misses         5846     5844       -2     
- Partials       1016     1017       +1
Flag Coverage Δ Complexity Δ
#unittests 75.55% <ø> (ø) 638 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...ssdk/core/internal/async/FileAsyncRequestBody.java 84.76% <0%> (+0.95%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576c49d...530e62d. Read the comment docs.

@zoewangg zoewangg merged commit 71af9cf into master Jan 9, 2020
@zoewangg zoewangg deleted the zoewang-taggingForCreateMultipartUpload branch January 9, 2020 00:06
aws-sdk-java-automation added a commit that referenced this pull request Aug 2, 2021
…c571632eb

Pull request: release <- staging/fee90b91-ed8b-4797-aa4f-7e8c571632eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants