Skip to content

Revert "Merge pull request #1602 from aws/millem/global-service-error-improvements" #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

millems
Copy link
Contributor

@millems millems commented Jan 21, 2020

No description provided.

…-improvements"

This reverts commit e748cb4, reversing
changes made to dff6955.
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@millems millems merged commit 9a2b7e9 into master Jan 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #1604 into master will decrease coverage by 0.13%.
The diff coverage is 56.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1604      +/-   ##
============================================
- Coverage     75.75%   75.62%   -0.14%     
  Complexity      638      638              
============================================
  Files           899      898       -1     
  Lines         28213    28141      -72     
  Branches       2229     2221       -8     
============================================
- Hits          21373    21281      -92     
- Misses         5821     5841      +20     
  Partials       1019     1019
Flag Coverage Δ Complexity Δ
#unittests 75.62% <56.81%> (-0.14%) 638 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
...oftware/amazon/awssdk/regions/ServiceMetadata.java 36.36% <ø> (ø) 0 <0> (ø) ⬇️
.../awssdk/awscore/client/config/AwsClientOption.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...ons/servicemetadata/EnhancedS3ServiceMetadata.java 81.25% <ø> (-0.57%) 0 <0> (ø)
...zon/awssdk/codegen/lite/regions/model/Service.java 64.7% <ø> (-5.89%) 0 <0> (ø)
.../awscore/client/handler/AwsClientHandlerUtils.java 73.46% <ø> (-0.54%) 0 <0> (ø)
.../amazon/awssdk/regions/DefaultServiceMetadata.java 88.88% <ø> (-1.12%) 0 <0> (ø)
...e/amazon/awssdk/awscore/AwsExecutionAttribute.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...odegen/lite/maven/plugin/RegionGenerationMojo.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...interceptor/GlobalServiceExecutionInterceptor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...wscore/client/builder/AwsDefaultClientBuilder.java 76.74% <100%> (-3.26%) 0 <0> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e748cb4...2274c61. Read the comment docs.

@millems millems deleted the millem/revert-global-service-error-improvements branch March 17, 2020 23:33
aws-sdk-java-automation added a commit that referenced this pull request Aug 12, 2021
…c4e09658a

Pull request: release <- staging/affd8226-2205-4691-9df6-309c4e09658a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants