Skip to content

Fixed s3 decoding response for ListObjectsVersion and ListMultipartUploads #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Feb 1, 2020

Description

Fixed an issue where fields in ListObjectVersionsResponse and ListMultipartUploadsResponse are not decoded correctly when encodingType is specified as url. See #1601

Testing

Added unit tests and integ tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@@ -17,16 +17,22 @@

import static software.amazon.awssdk.utils.http.SdkHttpUtils.urlDecode;

import java.util.Collections;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should consider adding a backlog task to automate at least catching future S3 operations that expose similar behavior?

We could probably make it as simple as operations that have an encodingType parameter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

Codecov Report

Merging #1630 into master will decrease coverage by <.01%.
The diff coverage is 87.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1630      +/-   ##
===========================================
- Coverage     75.71%   75.7%   -0.01%     
  Complexity      683     683              
===========================================
  Files           907     907              
  Lines         28365   28402      +37     
  Branches       2257    2259       +2     
===========================================
+ Hits          21476   21503      +27     
- Misses         5868    5875       +7     
- Partials       1021    1024       +3
Flag Coverage Δ Complexity Δ
#unittests 75.7% <87.03%> (-0.01%) 683 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
.../handlers/DecodeUrlEncodedResponseInterceptor.java 86.36% <87.03%> (-3.3%) 0 <0> (ø)
...nio/netty/internal/OldConnectionReaperHandler.java 81.81% <0%> (-9.1%) 0% <0%> (ø)
...ssdk/core/internal/async/FileAsyncRequestBody.java 83.8% <0%> (-0.96%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138def2...a4a2a26. Read the comment docs.

@zoewangg zoewangg merged commit 6a7d315 into master Feb 3, 2020
@zoewangg zoewangg deleted the zoewang-s3ListObjectVersions branch March 12, 2020 21:00
aws-sdk-java-automation pushed a commit that referenced this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants