Skip to content

Mark a connection as unreusable if there was a 5xx error so that new … #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2020

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Apr 6, 2020

Description

Mark a connection as unreusable if there was a 5xx error so that new request will execute on new connection

  • h1: closing connection after the request is complete
  • h2: stopping creating streams on that connection and closing the connection once there are no more streams on it.

Testing

Add functional tests
integ tests and stability tests pass
Baking the changes in canaries now.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg force-pushed the zoewang/connection5xxError branch from 8e75cff to d62ea23 Compare April 7, 2020 00:08
@codecov-io
Copy link

codecov-io commented Apr 7, 2020

Codecov Report

Merging #1768 into master will decrease coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1768      +/-   ##
============================================
- Coverage     76.29%   76.29%   -0.01%     
  Complexity      182      182              
============================================
  Files          1072     1073       +1     
  Lines         32252    32329      +77     
  Branches       2520     2536      +16     
============================================
+ Hits          24607    24664      +57     
- Misses         6404     6418      +14     
- Partials       1241     1247       +6     
Flag Coverage Δ Complexity Δ
#unittests 76.29% <85.71%> (-0.01%) 182.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
.../enhanced/dynamodb/model/QueryEnhancedRequest.java 61.64% <64.70%> (+0.24%) 0.00 <0.00> (ø)
...k/enhanced/dynamodb/model/ScanEnhancedRequest.java 61.40% <64.70%> (+0.42%) 0.00 <0.00> (ø)
...etty/internal/http2/Http2ToHttpInboundAdapter.java 71.87% <90.90%> (+8.23%) 0.00 <0.00> (ø)
...wssdk/http/nio/netty/internal/ResponseHandler.java 89.30% <100.00%> (+0.20%) 0.00 <0.00> (ø)
...nal/http2/Http2ConnectionTerminatingException.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...ty/internal/http2/Http2MultiplexedChannelPool.java 76.75% <100.00%> (ø) 0.00 <0.00> (ø)
...ty/internal/http2/Http2StreamExceptionHandler.java 90.90% <100.00%> (-0.76%) 0.00 <0.00> (ø)
...d/dynamodb/internal/operations/QueryOperation.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ed/dynamodb/internal/operations/ScanOperation.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...nio/netty/internal/OldConnectionReaperHandler.java 81.81% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43fabc9...56fe41f. Read the comment docs.

@zoewangg zoewangg force-pushed the zoewang/connection5xxError branch from 30270f7 to 56fe41f Compare April 7, 2020 20:49
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

96.7% 96.7% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit 3d2e2e5 into master Apr 13, 2020
@zoewangg zoewangg deleted the zoewang/connection5xxError branch April 13, 2020 17:30
@zoewangg zoewangg mentioned this pull request May 5, 2020
13 tasks
aws-sdk-java-automation pushed a commit that referenced this pull request Oct 15, 2021
Revert "Attempt to fix the flakiness of the codegen-generated-classes…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants