Skip to content

Various performance improvements. #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

millems
Copy link
Contributor

@millems millems commented Apr 24, 2020

Benchmarks in progress.

@millems millems force-pushed the millem/performance-improvements branch from c728f52 to e36c6c3 Compare April 24, 2020 21:15
@millems millems force-pushed the millem/performance-improvements branch from e36c6c3 to 1097bda Compare April 24, 2020 22:35
@millems millems merged commit 5a892e4 into master Apr 24, 2020
@millems millems deleted the millem/performance-improvements branch April 24, 2020 22:55
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 8 Code Smells

61.5% 61.5% Coverage
11.4% 11.4% Duplication

@millems
Copy link
Contributor Author

millems commented Apr 25, 2020

Before Change:

Benchmark                                                                               (sslProviderValue)  (testItem)    Mode     Cnt        Score        Error  Units
s.a.a.b.apicall.httpclient.async.NettyClientH1NonTlsBenchmark.concurrentApiCall                        N/A         N/A   thrpt      10    11245.811 ?    287.866  ops/s
s.a.a.b.apicall.httpclient.async.NettyClientH1NonTlsBenchmark.sequentialApiCall                        N/A         N/A   thrpt      10     3197.988 ?     30.884  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH1Benchmark.concurrentApiCall                          jdk         N/A   thrpt      10    10368.854 ?    152.575  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH1Benchmark.concurrentApiCall                      openssl         N/A   thrpt      10    10605.050 ?    107.683  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH1Benchmark.sequentialApiCall                          jdk         N/A   thrpt      10     2756.870 ?     27.622  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH1Benchmark.sequentialApiCall                      openssl         N/A   thrpt      10     2821.305 ?     60.341  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH2Benchmark.concurrentApiCall                          jdk         N/A   thrpt      10     6242.370 ?     67.031  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH2Benchmark.concurrentApiCall                      openssl         N/A   thrpt      10     7132.845 ?     72.225  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH2Benchmark.sequentialApiCall                          jdk         N/A   thrpt      10     2285.479 ?     30.133  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH2Benchmark.sequentialApiCall                      openssl         N/A   thrpt      10     2396.177 ?     17.290  ops/s
s.a.a.b.apicall.httpclient.sync.ApacheHttpClientBenchmark.concurrentApiCall                            N/A         N/A   thrpt      10    15902.702 ?     93.379  ops/s
s.a.a.b.apicall.httpclient.sync.ApacheHttpClientBenchmark.sequentialApiCall                            N/A         N/A   thrpt      10     3880.689 ?     96.634  ops/s
s.a.a.b.apicall.httpclient.sync.UrlConnectionHttpClientBenchmark.sequentialApiCall                     N/A         N/A   thrpt      10      765.424 ?     15.950  ops/s
s.a.a.b.apicall.protocol.Ec2ProtocolBenchmark.successfulResponse                                       N/A         N/A   thrpt      10     9510.425 ?     35.961  ops/s
s.a.a.b.apicall.protocol.JsonProtocolBenchmark.successfulResponse                                      N/A         N/A   thrpt      10    15343.291 ?    106.156  ops/s
s.a.a.b.apicall.protocol.QueryProtocolBenchmark.successfulResponse                                     N/A         N/A   thrpt      10    10340.202 ?    100.980  ops/s
s.a.a.b.apicall.protocol.XmlProtocolBenchmark.successfulResponse                                       N/A         N/A   thrpt      10     8670.604 ?    109.115  ops/s

After Change:

Benchmark                                                                               (sslProviderValue)  (testItem)    Mode     Cnt        Score        Error  Units
s.a.a.b.apicall.httpclient.async.NettyClientH1NonTlsBenchmark.concurrentApiCall                        N/A         N/A   thrpt      10    14122.509 ?    131.076  ops/s
s.a.a.b.apicall.httpclient.async.NettyClientH1NonTlsBenchmark.sequentialApiCall                        N/A         N/A   thrpt      10     3457.482 ?     30.247  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH1Benchmark.concurrentApiCall                          jdk         N/A   thrpt      10    12422.813 ?    138.608  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH1Benchmark.concurrentApiCall                      openssl         N/A   thrpt      10    12613.108 ?    318.684  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH1Benchmark.sequentialApiCall                          jdk         N/A   thrpt      10     2975.029 ?     18.522  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH1Benchmark.sequentialApiCall                      openssl         N/A   thrpt      10     3043.285 ?     56.311  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH2Benchmark.concurrentApiCall                          jdk         N/A   thrpt      10     6585.652 ?     70.420  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH2Benchmark.concurrentApiCall                      openssl         N/A   thrpt      10     7561.217 ?     97.082  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH2Benchmark.sequentialApiCall                          jdk         N/A   thrpt      10     2507.358 ?     16.469  ops/s
s.a.a.b.apicall.httpclient.async.NettyHttpClientH2Benchmark.sequentialApiCall                      openssl         N/A   thrpt      10     2613.694 ?     17.699  ops/s
s.a.a.b.apicall.httpclient.sync.ApacheHttpClientBenchmark.concurrentApiCall                            N/A         N/A   thrpt      10    17899.993 ?    217.164  ops/s
s.a.a.b.apicall.httpclient.sync.ApacheHttpClientBenchmark.sequentialApiCall                            N/A         N/A   thrpt      10     4346.483 ?    103.673  ops/s
s.a.a.b.apicall.httpclient.sync.UrlConnectionHttpClientBenchmark.sequentialApiCall                     N/A         N/A   thrpt      10      798.077 ?      5.132  ops/s
s.a.a.b.apicall.protocol.Ec2ProtocolBenchmark.successfulResponse                                       N/A         N/A   thrpt      10    11387.648 ?    191.272  ops/s
s.a.a.b.apicall.protocol.JsonProtocolBenchmark.successfulResponse                                      N/A         N/A   thrpt      10    19420.380 ?    324.009  ops/s
s.a.a.b.apicall.protocol.QueryProtocolBenchmark.successfulResponse                                     N/A         N/A   thrpt      10    12269.337 ?    417.780  ops/s
s.a.a.b.apicall.protocol.XmlProtocolBenchmark.successfulResponse                                       N/A         N/A   thrpt      10    10276.002 ?    138.007  ops/s

aws-sdk-java-automation added a commit that referenced this pull request Oct 25, 2021
…9b39e6934

Pull request: release <- staging/29786892-ce38-458f-802a-8f19b39e6934
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants