Skip to content

Update design docs based on meetings with team #1802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update design docs based on meetings with team #1802

wants to merge 3 commits into from

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Apr 30, 2020

Description

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

bmaizels
bmaizels reviewed Apr 30, 2020
View reviewed changes
bmaizels
bmaizels reviewed May 4, 2020
View reviewed changes
@dagnir dagnir force-pushed the metrics-design-update branch 2 times, most recently from 6211601 to ad15f26 Compare May 5, 2020 17:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@dagnir
Copy link
Contributor Author

dagnir commented May 15, 2020

Mostly superseded by #1844. Will move the docs update there as well

@dagnir dagnir closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmaizels bmaizels bmaizels left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dagnir @bmaizels