Skip to content

Link to raw IDE files instead of GitHub index pages #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020

Conversation

anuraaga
Copy link
Contributor

Description

Replace index links to IDE config files to the direct source files.

Motivation and Context

These files can only really be used by downloading them to be imported by IntelliJ. My first reaction to the page was to right click -> save as the links to get them ready to import, which doesn't work for import pages. I think users will generally be expecting these links to go straight to the file, but it's just a hunch so feel free to close if others don't agree :)

Types of changes

Just README

Checklist

  • [X ] I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • X[ ] I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • [X ] I confirm that this pull request can be released under the Apache 2 license

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@zoewangg zoewangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@zoewangg zoewangg merged commit 03fa2bb into aws:master May 21, 2020
aws-sdk-java-automation added a commit that referenced this pull request Nov 17, 2021
…5ccfd5867

Pull request: release <- staging/3488669f-5237-4fcc-ac2f-b0e5ccfd5867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants