Skip to content

Add default impls of SPI classes #1859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2020

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented May 21, 2020

Description

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir dagnir force-pushed the spi-impl branch 3 times, most recently from 2e7e195 to 4d033e1 Compare May 21, 2020 22:17
@dagnir dagnir changed the base branch from master to sdk-metrics-development-2 May 21, 2020 23:42
@codecov-commenter
Copy link

Codecov Report

Merging #1859 into sdk-metrics-development-2 will increase coverage by 0.07%.
The diff coverage is 83.67%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##             sdk-metrics-development-2    #1859      +/-   ##
===============================================================
+ Coverage                        76.20%   76.28%   +0.07%     
- Complexity                         187      225      +38     
===============================================================
  Files                             1075     1083       +8     
  Lines                            32552    32650      +98     
  Branches                          2566     2571       +5     
===============================================================
+ Hits                             24807    24906      +99     
  Misses                            6486     6486              
+ Partials                          1259     1258       -1     
Flag Coverage Δ Complexity Δ
#unittests 76.28% <83.67%> (+0.07%) 225.00 <38.00> (+38.00)
Impacted Files Coverage Δ Complexity Δ
...mazon/awssdk/metrics/internal/util/MetricUtil.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...software/amazon/awssdk/metrics/MetricCategory.java 61.53% <61.53%> (ø) 2.00 <2.00> (?)
...azon/awssdk/metrics/internal/DefaultSdkMetric.java 93.10% <93.10%> (ø) 14.00 <14.00> (?)
...ssdk/metrics/internal/DefaultMetricCollection.java 94.11% <94.11%> (ø) 6.00 <6.00> (?)
...wssdk/metrics/internal/DefaultMetricCollector.java 95.65% <95.65%> (ø) 10.00 <10.00> (?)
...oftware/amazon/awssdk/metrics/MetricCollector.java 100.00% <100.00%> (ø) 1.00 <1.00> (?)
...java/software/amazon/awssdk/metrics/SdkMetric.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...n/awssdk/metrics/internal/DefaultMetricRecord.java 100.00% <100.00%> (ø) 3.00 <3.00> (?)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6a6dc...aacca6f. Read the comment docs.

* @param metricCollection The collection of metrics.
* @throws IllegalArgumentException If {@code metricCollection} is {@code null}.
*/
void publish(MetricCollection metricCollection);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having second thought about the naming... I feel this is more of a notifying method and publish might not be accurate here. For example, a logging publisher might not publish and just log the data. How about onMetric or onMetricCollection?

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@dagnir dagnir merged commit 5af6d87 into aws:sdk-metrics-development-2 May 27, 2020
aws-sdk-java-automation added a commit that referenced this pull request Dec 2, 2021
…ed0cd7de8

Pull request: release <- staging/ea960aa2-4bec-414c-9f88-141ed0cd7de8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants