-
Notifications
You must be signed in to change notification settings - Fork 914
Add default impls of SPI classes #1859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2e7e195
to
4d033e1
Compare
Codecov Report
@@ Coverage Diff @@
## sdk-metrics-development-2 #1859 +/- ##
===============================================================
+ Coverage 76.20% 76.28% +0.07%
- Complexity 187 225 +38
===============================================================
Files 1075 1083 +8
Lines 32552 32650 +98
Branches 2566 2571 +5
===============================================================
+ Hits 24807 24906 +99
Misses 6486 6486
+ Partials 1259 1258 -1
Continue to review full report at Codecov.
|
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/MetricCollection.java
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/MetricCollector.java
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/SdkMetric.java
Outdated
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/internal/util/MetricUtil.java
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/internal/DefaultSdkMetric.java
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/MetricCategory.java
Outdated
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/MetricCollection.java
Show resolved
Hide resolved
* @param metricCollection The collection of metrics. | ||
* @throws IllegalArgumentException If {@code metricCollection} is {@code null}. | ||
*/ | ||
void publish(MetricCollection metricCollection); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having second thought about the naming... I feel this is more of a notifying method and publish
might not be accurate here. For example, a logging publisher might not publish
and just log the data. How about onMetric
or onMetricCollection
?
...cs-spi/src/test/java/software/amazon/awssdk/metrics/internal/DefaultMetricCollectorTest.java
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/MetricCollection.java
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/MetricCollector.java
Outdated
Show resolved
Hide resolved
core/metrics-spi/src/main/java/software/amazon/awssdk/metrics/SdkMetric.java
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed.
|
…ed0cd7de8 Pull request: release <- staging/ea960aa2-4bec-414c-9f88-141ed0cd7de8
Description
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsLicense