Skip to content

Stricter implementation of ARN rules when parsing resource strings. R… #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bmaizels
Copy link
Contributor

…equired to support paths properly in S3 operations that take ARNs

License

  • I confirm that this pull request can be released under the Apache 2 license

…equired to support paths properly in S3 operations that take ARNs
@bmaizels bmaizels requested a review from cenedhryn June 11, 2020 21:33
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2020

Codecov Report

Merging #1890 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1890      +/-   ##
============================================
+ Coverage     76.22%   76.23%   +0.01%     
- Complexity      187      193       +6     
============================================
  Files          1076     1076              
  Lines         32573    32588      +15     
  Branches       2569     2574       +5     
============================================
+ Hits          24828    24845      +17     
+ Misses         6487     6485       -2     
  Partials       1258     1258              
Flag Coverage Δ Complexity Δ
#unittests 76.23% <100.00%> (+0.01%) 193.00 <9.00> (+6.00)
Impacted Files Coverage Δ Complexity Δ
.../java/software/amazon/awssdk/arns/ArnResource.java 86.76% <100.00%> (+3.74%) 20.00 <9.00> (+6.00)
...mazon/awssdk/utils/async/DelegatingSubscriber.java 77.77% <0.00%> (-22.23%) 0.00% <0.00%> (ø%)
...k/core/pagination/async/ResponsesSubscription.java 68.00% <0.00%> (-16.00%) 0.00% <0.00%> (ø%)
...o/netty/internal/utils/BetterFixedChannelPool.java 58.04% <0.00%> (+1.72%) 0.00% <0.00%> (ø%)
...ssdk/core/internal/async/FileAsyncRequestBody.java 87.61% <0.00%> (+4.76%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117b2fe...668d46f. Read the comment docs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

aws-sdk-java-automation added a commit that referenced this pull request Jan 11, 2022
…97319a224

Pull request: release <- staging/d867a9f6-aaed-4341-b251-d1997319a224
@millems
Copy link
Contributor

millems commented Sep 29, 2022

Request is stale and was never merged. We'll re-open if this is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants