Skip to content

Fix missing token #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2020
Merged

Fix missing token #1893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57f0e2b
Added missing clientRequestToken to TransactWriteItemsEnhancedRequest
Quanzzzz Jun 11, 2020
f3c8755
Resolved commments and added a changelog.
Quanzzzz Jun 12, 2020
24b3c3d
Merge branch 'master' into fix-missing-token
Quanzzzz Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/next-release/bugfix-AWSSDKforJavav2DynamoDBEnhancedClient-6f19e6f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"category": "AWS SDK for Java v2 DynamoDB Enhanced Client",
"type": "bugfix",
"description": "Added ClientRequestToken in class TransactWriteItemsEnhancedRequest."
}
4 changes: 2 additions & 2 deletions ...ava/software/amazon/awssdk/enhanced/dynamodb/model/TransactWriteItemsEnhancedRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public final class TransactWriteItemsEnhancedRequest {

private final List<TransactWriteItem> transactWriteItems;

private String clientRequestToken;
private final String clientRequestToken;

private TransactWriteItemsEnhancedRequest(Builder builder) {
this.transactWriteItems = getItemsFromSupplier(builder.itemSupplierList);
Expand Down Expand Up @@ -107,7 +107,7 @@ public int hashCode() {
public static final class Builder {
private List<Supplier<TransactWriteItem>> itemSupplierList = new ArrayList<>();

private String clientRequestToken = null;
private String clientRequestToken;

private Builder() {
}
Expand Down
2 changes: 1 addition & 1 deletion ...software/amazon/awssdk/enhanced/dynamodb/model/TransactWriteItemsEnhancedRequestTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public void builder_maximal_builder_style() {
}

@Test
public void setClientRequestTokenTest() {
public void builder_passRequestToken_shouldWork() {
String token = UUID.randomUUID().toString();
TransactWriteItemsEnhancedRequest enhancedRequest = TransactWriteItemsEnhancedRequest.builder()
.clientRequestToken(token)
Expand Down