Skip to content

Updated the metrics design to include details on how metrics can be enabled at the request level, client level and global level. #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

millems
Copy link
Contributor

@millems millems commented Jun 24, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #1926 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1926      +/-   ##
============================================
+ Coverage     76.24%   76.27%   +0.02%     
  Complexity      187      187              
============================================
  Files          1076     1076              
  Lines         32573    32575       +2     
  Branches       2569     2569              
============================================
+ Hits          24835    24845      +10     
+ Misses         6478     6471       -7     
+ Partials       1260     1259       -1     
Flag Coverage Δ Complexity Δ
#unittests 76.27% <ø> (+0.02%) 187.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...nio/netty/internal/OldConnectionReaperHandler.java 81.81% <0.00%> (-9.10%) 0.00% <0.00%> (ø%)
...amodb/internal/operations/DeleteItemOperation.java 94.87% <0.00%> (+0.27%) 0.00% <0.00%> (ø%)
.../http/nio/netty/internal/NettyRequestExecutor.java 74.24% <0.00%> (+5.55%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc38805...3b8c031. Read the comment docs.

…nabled at the request level, client level and global level.
@millems millems force-pushed the millem/metrics-configuration-design branch from 7da65ba to 3b8c031 Compare June 24, 2020 21:44

**Environment Variable:** `AWS_METRIC_PUBLISHING_ENABLED=true`

The value specified must be one of `"true"` or `"false"`. Specifying any other string values will result in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make it case insensitive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, as we talked about, though, we should use what other booleans do, first and foremost.

@millems millems merged commit 12f3afd into master Jun 30, 2020
@millems millems deleted the millem/metrics-configuration-design branch June 30, 2020 23:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

aws-sdk-java-automation added a commit that referenced this pull request Feb 8, 2022
…5dc2178d1

Pull request: release <- staging/8a4a2ddb-ac6d-4fd2-bbb9-6875dc2178d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants