Remove DynamoDB and Metrics tests from the benchmark test suite, by default. This should make running benchmarks much more timely. #1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Aug 11, 2020
| benchmarksToRun.addAll(MAPPER_BENCHMARKS); | ||
| benchmarksToRun.addAll(METRIC_BENCHMARKS); | ||
|
|
||
| System.out.println("Skipping tests, to reduce benchmark times: \n" + |
There was a problem hiding this comment.
Do we need the log here? The benchmarksToRun will be printed out on line 112. If so, can we use the logger created on line 83
There was a problem hiding this comment.
The log is good to make it clear what isn't being run. It also makes it so that we don't have static private variables laying around. +1 to moving to the logger.
zoewangg
approved these changes
Aug 11, 2020
…efault. This should make running benchmarks much more timely.
millems
force-pushed
the
millem/reduce-benchmarks
branch
from
83692f6 to
f3faf5c
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
Apr 1, 2022
…60b7c6e49 Pull request: release <- staging/0f62d3cf-1573-4520-b697-a7c60b7c6e49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.