Skip to content

Fix Travis build #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Fix Travis build #2046

merged 2 commits into from
Sep 18, 2020

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Sep 18, 2020

Description

  • Add static creds in test client to bypass the default credentials chain
  • Suppress false positive bug

Motivation and Context

Fix Travis build.

Testing

Test build on Travis #2045

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

 - Add static creds in test client to bypass the default credentials chain
 - Suppress false positive bug
@@ -172,6 +172,14 @@
<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
</Match>

<!-- See SpotBugs bug: https://github.com/spotbugs/spotbugs/issues/600, https://github.com/spotbugs/spotbugs/issues/756 -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #2046 into master will increase coverage by 0.34%.
The diff coverage is 85.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2046      +/-   ##
============================================
+ Coverage     76.92%   77.26%   +0.34%     
- Complexity      225      226       +1     
============================================
  Files          1107     1134      +27     
  Lines         33507    34741    +1234     
  Branches       2573     2705     +132     
============================================
+ Hits          25774    26844    +1070     
- Misses         6453     6551      +98     
- Partials       1280     1346      +66     
Flag Coverage Δ Complexity Δ
#unittests 77.26% <85.62%> (+0.34%) 226.00 <0.00> (+1.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...n/awssdk/codegen/poet/client/ClientClassUtils.java 97.64% <ø> (ø) 0.00 <0.00> (ø)
...dk/codegen/poet/client/specs/JsonProtocolSpec.java 90.85% <ø> (+0.17%) 0.00 <0.00> (ø)
...dk/core/client/config/SdkAdvancedClientOption.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...e/amazon/awssdk/http/crt/AwsCrtSdkHttpService.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...amazon/awssdk/enhanced/dynamodb/TableMetadata.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...odel/config/customization/CustomizationConfig.java 95.49% <50.00%> (-1.71%) 0.00 <0.00> (ø)
...db/internal/mapper/StaticKeyAttributeMetadata.java 55.55% <55.55%> (ø) 0.00 <0.00> (?)
...on/awssdk/codegen/poet/client/SyncClientClass.java 91.22% <58.33%> (-5.40%) 0.00 <0.00> (ø)
.../dynamodb/internal/mapper/StaticIndexMetadata.java 66.66% <66.66%> (ø) 0.00 <0.00> (?)
...n/awssdk/codegen/poet/client/AsyncClientClass.java 91.26% <70.83%> (-5.68%) 0.00 <0.00> (ø)
... and 128 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4cbcb9...08909db. Read the comment docs.

@dagnir dagnir merged commit 65b260d into aws:master Sep 18, 2020
@dagnir dagnir deleted the travis-build-fix branch September 18, 2020 23:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

aws-sdk-java-automation added a commit that referenced this pull request May 31, 2022
…d9f1af6df

Pull request: release <- staging/c4413edd-4531-42ea-935c-733d9f1af6df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants