-
Notifications
You must be signed in to change notification settings - Fork 916
Add functional tests and integration tests for Waiters #2062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Quanzzzz
merged 1 commit into
aws:waiters-development
from
Quanzzzz:waiters-development
Sep 24, 2020
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
98 changes: 98 additions & 0 deletions
98
...dynamodb/src/it/java/software/amazon/awssdk/services/dynamodb/WaitersIntegrationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.awssdk.services.dynamodb; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.junit.Assert.assertTrue; | ||
|
||
import java.util.concurrent.CompletableFuture; | ||
import java.util.concurrent.ExecutionException; | ||
import org.junit.AfterClass; | ||
import org.junit.BeforeClass; | ||
import org.junit.Test; | ||
import software.amazon.awssdk.core.waiters.WaiterResponse; | ||
import software.amazon.awssdk.services.dynamodb.model.AttributeDefinition; | ||
import software.amazon.awssdk.services.dynamodb.model.CreateTableRequest; | ||
import software.amazon.awssdk.services.dynamodb.model.DeleteTableRequest; | ||
import software.amazon.awssdk.services.dynamodb.model.DescribeTableRequest; | ||
import software.amazon.awssdk.services.dynamodb.model.DescribeTableResponse; | ||
import software.amazon.awssdk.services.dynamodb.model.KeySchemaElement; | ||
import software.amazon.awssdk.services.dynamodb.model.KeyType; | ||
import software.amazon.awssdk.services.dynamodb.model.ProvisionedThroughput; | ||
import software.amazon.awssdk.services.dynamodb.model.ScalarAttributeType; | ||
import software.amazon.awssdk.services.dynamodb.waiters.DynamoDbAsyncWaiter; | ||
import software.amazon.awssdk.services.dynamodb.waiters.DynamoDbWaiter; | ||
import utils.resources.tables.BasicTempTable; | ||
import utils.test.util.DynamoDBTestBase; | ||
|
||
public class WaitersIntegrationTest extends DynamoDBTestBase { | ||
|
||
private static final String TABLE_NAME = "java-sdk-waiter-test" + System.currentTimeMillis(); | ||
private static final String HASH_KEY_NAME = BasicTempTable.HASH_KEY_NAME; | ||
private static DynamoDbAsyncClient dynamoAsync; | ||
|
||
@BeforeClass | ||
public static void setUp() { | ||
DynamoDBTestBase.setUpTestBase(); | ||
|
||
dynamoAsync = DynamoDbAsyncClient.builder().region(REGION).credentialsProvider(CREDENTIALS_PROVIDER_CHAIN).build(); | ||
|
||
dynamo.createTable(CreateTableRequest.builder().tableName(TABLE_NAME) | ||
.keySchema(KeySchemaElement.builder().keyType(KeyType.HASH) | ||
.attributeName(HASH_KEY_NAME) | ||
.build()) | ||
.attributeDefinitions(AttributeDefinition.builder() | ||
.attributeType(ScalarAttributeType.N) | ||
.attributeName(HASH_KEY_NAME) | ||
.build()) | ||
.provisionedThroughput(ProvisionedThroughput.builder() | ||
.readCapacityUnits(5L) | ||
.writeCapacityUnits(5L) | ||
.build()) | ||
.build()); | ||
} | ||
|
||
@AfterClass | ||
public static void cleanUp() { | ||
Quanzzzz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
dynamo.deleteTable(DeleteTableRequest.builder().tableName(TABLE_NAME).build()); | ||
|
||
dynamo.close(); | ||
dynamoAsync.close(); | ||
} | ||
|
||
@Test | ||
public void checkTableExist_withSyncWaiter() { | ||
DynamoDbWaiter syncWaiter = dynamo.waiter(); | ||
WaiterResponse<DescribeTableResponse> response = syncWaiter.waitUntilTableExists( | ||
DescribeTableRequest.builder().tableName(TABLE_NAME).build()); | ||
|
||
assertThat(response.attemptsExecuted()).isGreaterThanOrEqualTo(1); | ||
assertThat(response.matched().response().get().table().tableName()).isEqualTo(TABLE_NAME); | ||
} | ||
|
||
@Test | ||
public void checkTableExist_withAsyncWaiter() throws ExecutionException, InterruptedException { | ||
DynamoDbAsyncWaiter asyncWaiter = dynamoAsync.waiter(); | ||
CompletableFuture<WaiterResponse<DescribeTableResponse>> responseFuture = asyncWaiter.waitUntilTableExists( | ||
DescribeTableRequest.builder().tableName(TABLE_NAME).build()); | ||
|
||
responseFuture.join(); | ||
|
||
assertThat(responseFuture.get().attemptsExecuted()).isGreaterThanOrEqualTo(1); | ||
assertThat(responseFuture.get().matched().response().get().table().tableName()).isEqualTo(TABLE_NAME); | ||
} | ||
|
||
} |
145 changes: 145 additions & 0 deletions
145
...est/src/test/java/software/amazon/awssdk/services/waiters/WaitersAsyncFunctionalTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,145 @@ | ||
/* | ||
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"). | ||
* You may not use this file except in compliance with the License. | ||
* A copy of the License is located at | ||
* | ||
* http://aws.amazon.com/apache2.0 | ||
* | ||
* or in the "license" file accompanying this file. This file is distributed | ||
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
* express or implied. See the License for the specific language governing | ||
* permissions and limitations under the License. | ||
*/ | ||
|
||
package software.amazon.awssdk.services.waiters; | ||
Quanzzzz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.mockito.Matchers.any; | ||
import static org.mockito.Mockito.mock; | ||
import static org.mockito.Mockito.never; | ||
import static org.mockito.Mockito.verify; | ||
import static org.mockito.Mockito.when; | ||
|
||
import java.util.concurrent.CompletableFuture; | ||
import java.util.concurrent.ExecutionException; | ||
import java.util.concurrent.ScheduledExecutorService; | ||
import org.junit.After; | ||
import org.junit.Before; | ||
import org.junit.Test; | ||
import software.amazon.awssdk.core.exception.SdkServiceException; | ||
import software.amazon.awssdk.core.retry.backoff.BackoffStrategy; | ||
import software.amazon.awssdk.core.waiters.WaiterOverrideConfiguration; | ||
import software.amazon.awssdk.core.waiters.WaiterResponse; | ||
import software.amazon.awssdk.http.SdkHttpResponse; | ||
import software.amazon.awssdk.services.restjsonwithwaiters.RestJsonWithWaitersAsyncClient; | ||
import software.amazon.awssdk.services.restjsonwithwaiters.model.AllTypesRequest; | ||
import software.amazon.awssdk.services.restjsonwithwaiters.model.AllTypesResponse; | ||
import software.amazon.awssdk.services.restjsonwithwaiters.waiters.RestJsonWithWaitersAsyncWaiter; | ||
|
||
public class WaitersAsyncFunctionalTest { | ||
|
||
public RestJsonWithWaitersAsyncClient asyncClient; | ||
public RestJsonWithWaitersAsyncWaiter asyncWaiter; | ||
|
||
@Before | ||
public void setup() { | ||
asyncClient = mock(RestJsonWithWaitersAsyncClient.class); | ||
asyncWaiter = RestJsonWithWaitersAsyncWaiter.builder() | ||
.client(asyncClient) | ||
.overrideConfiguration(WaiterOverrideConfiguration.builder() | ||
.maxAttempts(3) | ||
.backoffStrategy(BackoffStrategy.none()) | ||
.build()) | ||
.build(); | ||
} | ||
|
||
@After | ||
public void cleanup() { | ||
asyncClient.close(); | ||
asyncWaiter.close(); | ||
} | ||
|
||
@Test | ||
public void allTypeOperation_withAsyncWaiter_shouldReturnResponse() throws ExecutionException, InterruptedException { | ||
AllTypesResponse response = (AllTypesResponse) AllTypesResponse.builder() | ||
.sdkHttpResponse(SdkHttpResponse.builder() | ||
.statusCode(200) | ||
.build()) | ||
.build(); | ||
|
||
CompletableFuture<AllTypesResponse> serviceFuture = new CompletableFuture<>(); | ||
|
||
|
||
when(asyncClient.allTypes(any(AllTypesRequest.class))).thenReturn(serviceFuture); | ||
CompletableFuture<WaiterResponse<AllTypesResponse>> responseFuture = asyncWaiter.waitUntilAllTypesSuccess(AllTypesRequest.builder() | ||
.integerMember(1) | ||
.build()); | ||
serviceFuture.complete(response); | ||
|
||
assertThat(responseFuture.get().attemptsExecuted()).isEqualTo(1); | ||
assertThat(responseFuture.get().matched().response()).hasValueSatisfying(r -> assertThat(r).isEqualTo(response)); | ||
} | ||
|
||
@Test | ||
public void allTypeOperationFailed_withAsyncWaiter_shouldReturnException() throws ExecutionException, InterruptedException { | ||
CompletableFuture<AllTypesResponse> serviceFuture = new CompletableFuture<>(); | ||
|
||
when(asyncClient.allTypes(any(AllTypesRequest.class))).thenReturn(serviceFuture); | ||
CompletableFuture<WaiterResponse<AllTypesResponse>> responseFuture = asyncWaiter.waitUntilAllTypesSuccess(AllTypesRequest.builder().build()); | ||
|
||
serviceFuture.completeExceptionally(SdkServiceException.builder().statusCode(200).build()); | ||
|
||
assertThat(responseFuture.get().attemptsExecuted()).isEqualTo(1); | ||
assertThat(responseFuture.get().matched().exception()).hasValueSatisfying(r -> assertThat(r).isInstanceOf(SdkServiceException.class)); | ||
} | ||
|
||
@Test | ||
public void allTypeOperationRetry_withAsyncWaiter_shouldReturnResponseAfterException() throws ExecutionException, InterruptedException { | ||
AllTypesResponse response1 = (AllTypesResponse) AllTypesResponse.builder() | ||
.sdkHttpResponse(SdkHttpResponse.builder() | ||
.statusCode(404) | ||
.build()) | ||
.build(); | ||
AllTypesResponse response2 = (AllTypesResponse) AllTypesResponse.builder() | ||
.sdkHttpResponse(SdkHttpResponse.builder() | ||
.statusCode(200) | ||
.build()) | ||
.build(); | ||
|
||
CompletableFuture<AllTypesResponse> serviceFuture1 = new CompletableFuture<>(); | ||
CompletableFuture<AllTypesResponse> serviceFuture2 = new CompletableFuture<>(); | ||
|
||
when(asyncClient.allTypes(any(AllTypesRequest.class))).thenReturn(serviceFuture1, serviceFuture2); | ||
|
||
CompletableFuture<WaiterResponse<AllTypesResponse>> responseFuture = asyncWaiter.waitUntilAllTypesSuccess(AllTypesRequest.builder().build()); | ||
|
||
serviceFuture1.complete(response1); | ||
serviceFuture2.complete(response2); | ||
|
||
assertThat(responseFuture.get().attemptsExecuted()).isEqualTo(2); | ||
assertThat(responseFuture.get().matched().response()).hasValueSatisfying(r -> assertThat(r).isEqualTo(response2)); | ||
} | ||
|
||
@Test | ||
public void closeWaiterCreatedWithClient_clientDoesNotClose() { | ||
asyncWaiter.close(); | ||
verify(asyncClient, never()).close(); | ||
} | ||
|
||
@Test | ||
public void closeWaiterCreatedWithExecutorService_executorServiceDoesNotClose() { | ||
ScheduledExecutorService executorService = mock(ScheduledExecutorService.class); | ||
RestJsonWithWaitersAsyncWaiter newWaiter = RestJsonWithWaitersAsyncWaiter.builder() | ||
.scheduledExecutorService(executorService) | ||
.overrideConfiguration(WaiterOverrideConfiguration.builder() | ||
.maxAttempts(3) | ||
.backoffStrategy(BackoffStrategy.none()) | ||
.build()) | ||
.build(); | ||
|
||
newWaiter.close(); | ||
verify(executorService, never()).shutdown(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.