Various renaming and provide default values for waiterOverrideConfiguration #2063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
force-pushed
the
zoewang/waiters/renaming
branch
from
206e95e to
6ea0442
Compare
millems
reviewed
Sep 23, 2020
codegen/src/main/java/software/amazon/awssdk/codegen/docs/WaiterDocs.java
Outdated
Show resolved
Hide resolved
.../sdk-core/src/main/java/software/amazon/awssdk/core/internal/waiters/DefaultAsyncWaiter.java
Outdated
Show resolved
Hide resolved
...dk-core/src/main/java/software/amazon/awssdk/core/internal/waiters/WaiterExecutorHelper.java
Outdated
Show resolved
Hide resolved
...dk-core/src/main/java/software/amazon/awssdk/core/internal/waiters/WaiterExecutorHelper.java
Outdated
Show resolved
Hide resolved
...dk-core/src/main/java/software/amazon/awssdk/core/internal/waiters/WaiterExecutorHelper.java
Outdated
Show resolved
Hide resolved
millems
approved these changes
Sep 23, 2020
zoewangg
force-pushed
the
zoewang/waiters/renaming
branch
from
bf863b7 to
81138f4
Compare
|
SonarCloud Quality Gate failed.
|
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jun 21, 2022
…6d7c323cb Pull request: release <- staging/94221469-a490-4e2c-ba8d-ae26d7c323cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
{Service}Waiter.Builder#executorService->{Service}Waiter.Builder#scheduledExecutorServicePollingStratege->WaiterOverrideConfigurationandWaiter.Builder#pollingStrategy->Waiter.Builder#overrideConfigurationWaiterResponse#responseOrExecption->WaiterResponse#matchedwaiterOverrideConfigurationmaxWaitTime->waitTimeoutMotivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense