Skip to content

add per request waiterOverrideConfiguration overloaded waiter operation #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2020
Merged

add per request waiterOverrideConfiguration overloaded waiter operation #2066

merged 1 commit into from
Sep 28, 2020

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Sep 25, 2020 •
edited
Loading

Description

  • add per request waiterOverrideConfiguration overloaded waiter operation
  • remove throwOnUnmatchedExceptionWaiter from WaitersRuntime because it would cause async waiter future to hang. unmatched exception is handled in the generic waiter implementations
  • add try-catch in generic async waiter whenComplete block to fix the issue where any exception thrown there could cause the future to hang
  • add more functional tests

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

dagnir
dagnir reviewed Sep 25, 2020
View reviewed changes
@zoewangg zoewangg force-pushed the zoewang/waiters/requestLevelConfigOverload branch from 6721438 to 0f97f94 Compare September 28, 2020 17:05
@zoewangg
Add request level override config overload
c3de0f7 
Fixed a bug where an exception thrown in waiterAcceptor could cause the async waiter operations to hang

Add request override config overload in Waiter
@zoewangg zoewangg force-pushed the zoewang/waiters/requestLevelConfigOverload branch from 0f97f94 to c3de0f7 Compare September 28, 2020 17:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 10 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@zoewangg zoewangg merged commit ead3b78 into waiters-development Sep 28, 2020
@zoewangg zoewangg deleted the zoewang/waiters/requestLevelConfigOverload branch September 28, 2020 18:59
aws-sdk-java-automation added a commit that referenced this pull request Jun 24, 2022
@aws-sdk-java-automation
Merge pull request #2066 from aws/staging/ba3ca818-9079-4648-85be-93e…
fa6e308 
…c2189a5cc

Pull request: release <- staging/ba3ca818-9079-4648-85be-93ec2189a5cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagnir dagnir dagnir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoewangg @dagnir